CODEWITHSUNDEEP
androidnull
Adz
Adz

Reputation: 2847

EditText keeps returning null?

public class Input extends FragmentActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);


    EditText mEditText1 = (EditText)findViewById(R.id.number1i); 
    String val1 = mEditText1.getText().toString();
    EditText mEditText2 = (EditText)findViewById(R.id.number2i); 
    String val2 = mEditText2.getText().toString();

    double dVal1 = Double.parseDouble(val1); 
    double dVal2 = Double.parseDouble(val2);


  } 
}

This is my xml file:

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical" 
    android:background="@drawable/background">

    <EditText
        android:id="@+id/number1i"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:ems="10"
        android:hint="Enter your first value"
        android:inputType="numberDecimal" />   

    <EditText
        android:id="@+id/number2i"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:ems="10"
        android:hint="Enter your second value"
        android:inputType="numberDecimal" />

    <TextView
        android:id="@+id/output"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:gravity="center"
        android:textSize="22sp" />

    <Button
        android:id="@+id/add_marker"
        android:layout_width="fill_parent"
        android:layout_height="wrap_content"
        android:layout_marginTop="20dp"
        android:text="Add value"
        android:onClick="userInput1"
        android:textSize="22sp" />   

</LinearLayout>

The error:

12-05 08:57:17.113: E/AndroidRuntime(8420): Caused by: java.lang.NullPointerException
12-05 08:57:17.113: E/AndroidRuntime(8420):     at com.example.whatever.input.onCreate(input.java:23)

Line 23 is

String val1 = mEditText1.getText().toString();

Any help please?

I would presume because the value could be empty?

Upvotes: 1

Views: 3357

Answers (5)

Unii
Unii

Reputation: 1617

 String val1 = mEditText1.getText().toString();
if(val1 != null && val1 !=""){
 double dVal1 = Double.parseDouble(val1); //+handle parse error
}

//but you should get text in onClick method

Upvotes: 2

Siddharth_Vyas
Siddharth_Vyas

Reputation: 10100

Change your xml EdiText Component to :

 <EditText
    android:id="@+id/number1i"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:ems="10"
    android:hint="Enter your first value"
    android:text="Test Value"                      << Add this line
    android:inputType="numberDecimal" />

Now try to run your code.

Hope this helps.

Upvotes: 0

Connecting life with Android
Connecting life with Android

Reputation: 3926

you can do null check for edittext.getText() & try it to put somewhere in code where you have an input for editext

Upvotes: 1

insomniac
insomniac

Reputation: 11766

Yes it is because the String val1 = mEditText1.getText().toString(); and String val2 = mEditText2.getText().toString(); are on onCreate() they are executed before the user puts anything to the edittext try using them in an on click listener

Upvotes: 2

Apoorv
Apoorv

Reputation: 13520

In your code mEditText1.getText() will always be empty in onCreate unless you have to set text in it from XML

Upvotes: 9

Related Questions