JSF setter called multiple time overwriting values

Question

Hi I am using PrimeFaces to create a data table which has 1 column within it and each row of that datatable holds a accordian. i want to update a specific row within the data table with the values from some input boxes associated with each row.

When I submit the form per row firstly the set property action listener is never called and secondly the setters for the fields I am updating are called multiple times. In fact they are called once for every row in the data table.

The problem being that when debugging I can see that no matter which ever row I am editing the setters are called for all the rows in the datatable. So unless i am editing the last row the values I am setting always get overwritten. Any one know whey this is happening as i thought it would only have called the setter once per row edit.

UPDATE: Worst case i can get around the setters being called by putting a null check in. however I do not know which row I am working with since the set property action listener is not called

JSF page



       
        
        

         
      
        
          
          
            
          
        

      

    


    

    
        

        
        
        
            
                  

                      
                           
                           Summary
                                 
                              
                            
                            Implication
                                 
                                       
                            
                                
                                       
                                                  
                              
                             

                             

                                     
                                                          
                            
                            Due Date  
                             
                            
                                
                             

                    
                
            
        
        

     

      
        Email Actions  
          
            #{action.action} --- #{action.username}

My backing bean

@ManagedBean
@Configurable
@ViewScoped
public class EmailArticleBean implements Serializable {

    /**
     * 
     */
    private static final long serialVersionUID = 1L;

    @Autowired
    EmailArticleService emailArticleService;

    private List emailArticles;
    private String searchText;
    private String emailAction;
    private EmailArticle selectedEmail;
    private Date actionDueDate;

    /**
     * Using the search term entered will
     * query the database and return a list of articles 
     * that match that parameter
     * @param ae
     */
    public void search(ActionEvent ae) {
        emailArticles = emailArticleService.findEmailArticles(searchText);
    }   

    /**
     * add the inputted action to the list of existing actions
     * @param ae
     */
    public void updateAction(ActionEvent ae) {
        selectedEmail.getActions().add(new EmailActions(emailAction, "testUser", actionDueDate));
        selectedEmail.merge();
        emailAction = "";
        actionDueDate = null;
    }

    public List getEmailArticles() {
        return emailArticles;
    }

    public void setEmailArticles(List emailArticles) {
        this.emailArticles = emailArticles;
    }

    public String getSearchText() {
        return searchText;
    }

    public void setSearchText(String searchText) {
        this.searchText = searchText;
    }

    public String getEmailAction() {
        return emailAction;
    }

    public void setEmailAction(String emailAction) {
        //putting this check in because it the jsf lifecycle
        //seems to be calling the setter once for every row overwriting the new value set by the user
        if(StringUtils.isEmpty(this.emailAction)) {
            this.emailAction = emailAction;
        }       
    }   

    public EmailArticle getSelectedEmail() {
        return selectedEmail;
    }

    public void setSelectedEmail(EmailArticle selectedEmail) {
        if(selectedEmail == null) {
            this.selectedEmail = selectedEmail;
        }       
    }

    public Date getActionDueDate() {
        return actionDueDate;
    }

    public void setActionDueDate(Date actionDueDate) {
        if(this.actionDueDate == null) {
            this.actionDueDate = actionDueDate;
        }       
    }


}

BalusC · Accepted Answer

You're indeed binding the value of the input field of all rows to one and same bean property.

...

Logically, this makes no sense. The symptoms which you described is exactly the expected consequence. You should be binding the value of the input field to the currently iterated row.

...

JSF setter called multiple time overwriting values

Answers (1)

Related Questions