CODEWITHSUNDEEP
phpobjectconstructorget
Rien
Rien

Reputation: 458

PHP create object inside it's own constructor

EDIT: Link to my first question. Might clear some things up. PHP Get corresponding data, with default and error handling

I have a function that checks if a GET statement exists. If so, it passes the value to a other function that then selects a class based on the value of the GET statement.

explaining: The url = Page=Contact
The GetFormVariable approves it, and the class Contact is selected and it will give back a string. This string is used as an object 'Content' that, as it says, creats the content of the page.

public function getFormVariable($value){

    switch (strtoupper($_SERVER['REQUEST_METHOD'])) {
        case 'GET':
            if (isset($_GET[$value]) && $_GET[$value] != NULL) {
                return $_GET[$value];
            }
            else{
                return false;
            }
            break;
            case 'POST':
                if (isset($POST[$value]) && $POST[$value] != NULL) {
                return $POST[$value];
            }
            else{
                    return false;
            }
                break;

        default:
            return false;

    }
}

Now the question. When there is no GET statement in the url. The GetFormVariable returns false. And this means there is nothing shown.

How do i give this constructor.

public function SetProperty ($prob, $val){
    $this->$prob = $val;
}

The information to create the ContentHome.
SetProperty('Content', 'ContentHome');

Sorry for poor explanation, if anything is unclear please tell me so.

Upvotes: 0

Views: 84

Answers (2)

quickshiftin
quickshiftin

Reputation: 69581

I'm suggesting we close this question as unclear what you're asking, but decided to throw some help on the provided code sample anyway...

You can strip this down dramatically, and since there's no context, the function can be static too.

static public function getFormVariable($value)
{
    if($_SERVER['REQUEST_METHOD'] == 'GET' &&
       isset($_GET[$value])                &&
       !empty($_GET[$value]))
        return $_GET[$value];

    elseif($_SERVER['REQUEST_METHOD'] == 'POST' &&
           isset($POST[$value])                 &&
           !empty($POST[$value]))
        return $POST[$value];

    return false;
}

Your original isset and != NULL checks were doing the same check. Maybe you want the empty() check as a third check, but look it up to be certain.

Upvotes: 1

Hector Ordonez
Hector Ordonez

Reputation: 1104

The question is unclear.

How you call getFormVariable? How you use SetProperty with the information getFormVariable provides?

As far as I understood, you mean this... 

$var = getFormVariable(???);

if (false === $var)
{
    SetProperty('Content', 'ContentHome');
} else {
    SetProperty('var', $var);
}

Upvotes: 0

Related Questions