CODEWITHSUNDEEP
javascriptonbeforeunload
Eslam Hamdy
Eslam Hamdy

Reputation: 7396

window.onbeforeunload executed on page refresh instead of on page close

I'm using window.onbeforeunload to pop up a confirm dialog when a close event occurs, but the confirm dialog appears on page refresh and doesn't execute on page close.

Here's the JavaScript code:

<script language="JavaScript">
    window.onbeforeunload = confirmWinClose();
    function confirmWinClose() {
        var confirmClose = confirm('Close?');
        return confirmClose;
    }    
</script>

I tried it on Chrome, Firefox and Internet Explorer.

Upvotes: 10

Views: 47804

Answers (4)

Neha
Neha

Reputation: 1548

Try this it will work. You were assigning the method to onload that need to execute when it event occur so its need to be like object. refer link for better explanation - var functionName = function() {} vs function functionName() {}

 window.onbeforeunload = confirmWinClose;
 function confirmWinClose () {
 var confirmClose = confirm('Close?');
 return confirmClose;
 };

Upvotes: 0

Daniel
Daniel

Reputation: 61

Since you anyway only want to display your text, What just using the onbeforeunload as it is expected just return the string?

<script language="JavaScript">
  window.onbeforeunload = confirmWinClose;
  function confirmWinClose() {return "close?";}
</script>

Upvotes: 0

gaurav5430
gaurav5430

Reputation: 13917

PROBLEM WITH YOUR CODE:

the function will be called when you refresh, because on refresh the page is unloaded and then reloaded.

in your solution, you should also note that you are not assigning a function to window.onbeforeunload but you are assigning the return value of the function when you write

window.onbeforeunload = confirmWinClose();

which might also execute the function (based on where you place it in the javascript) whenever the assignment is done. For e.g. 

function confirmWinClose() {
var confirmClose = confirm('Close?');
return confirmClose;
}

window.onbeforeunload = confirmWinClose();

the above code will execute the confirmWinClose function whenever this js is loaded.

(not your case as you have defined the function after call, so won't be executed on load, but you should remember this)

SOLUTION:

the below solution is working for close also

instead of your solution, i tried this

JS:

window.onbeforeunload = function() {
    var confirmClose = confirm('Close?');
    return confirmClose;
}

or 

 window.onbeforeunload = confirmWinClose; //note the absence of calling parantheses

    function confirmWinClose() {
        var confirmClose = confirm('Close?');
        return confirmClose;
    }

this works as expected.

also note that you should return from the onbeforeunload explicitly.

even if you have to call a function, you should do

<script>
    window.onbeforeunload = function(e) {
       callSomeFunction();
       return null;
    };
</script>

Upvotes: 9

Paul Rad
Paul Rad

Reputation: 4882

No full solution, but you can intercept the F5 key (not intercepted if the user click on the refresh browser button...)

var isRefresh = false;

// with jquery

$(function() {
  $(document).on("keydown", function(e) {
    if (e.which === 116)
    {
      isRefresh = true;
    }
  });
});

window.onbeforeunload = function() {
 if (! isRefresh)
 {
   return confirm ('Close ?');
 }
 return false;
};

Upvotes: 3

Related Questions