CODEWITHSUNDEEP
javascriptjquery
rootsup
rootsup

Reputation: 315

declared variable doesn't seem global

I declared my variable first - then have my jquery : 

var cimg = '';
jQuery(function($) {
    $(".trigger").click(function() {
  var cimg = event.target.id;
  clickedimage();
  loadPopup();
});
});

Then the script outside the jquery :

function clickedimage()
  {
    var xmargin  = $(cimg).width()/2;
    var ymargin = $(cimg).height()/2;
    $("#popupimage").css('margin-left',-xmargin+'px')
    $("#popupimage").css('margin-top',-ymargin+'px')
    var Clicked = cimg.src;
    $('#popupimage').attr('src',Clicked);
  }

It doesn't seem to want to take on the cimg value supplied from the .trigger clicked event

What am I doing wrong here?

Upvotes: 2

Views: 61

Answers (2)

gen_Eric
gen_Eric

Reputation: 227310

In the click event you do var cimg = ...;. The var keyword tells it to create a new local variable instead of using the one from the outer scope.

Remove the var inside the handler.

var cimg = '';
jQuery(function($) {
    $(".trigger").click(function(event) {
        cimg = event.target.id;
        clickedimage();
        loadPopup();
    });
});

Upvotes: 5

Samuli Hakoniemi
Samuli Hakoniemi

Reputation: 19069

You redeclaring var cimg which causes it to be a local variable inside function scope. In addition, you're not providing event, which also causes an error (some browsers allow referring to window.event though).

jQuery(function($) {
    $(".trigger").click(function(event) {
        cimg = event.target.id;
        clickedimage();
        loadPopup();
    });
});

Upvotes: 1

Related Questions