CODEWITHSUNDEEP
javascriptangularjsfirebaseangularfire
Dan Kanze
Dan Kanze

Reputation: 18595

$on loaded fires once for new references AngularFire 0.5.0

Let's say were using pushState to navigate routes:

$locationProvider.html5Mode(true);

And there are two routes with two different controllers:

$stateProvider.state('one', {
  url:'/one',
  templateUrl:'one.html',
  controller: 'oneCtrl'
});

$stateProvider.state('two', {
  url:'/two',
  templateUrl:'two.html',
  controller: 'twoCtrl'
});

oneCtrl creates a new reference to the same resource as twoCtrl:

.controller('oneCtrl', ["$scope", "$firebase", function($scope, $firebase) {

  var oneRef = new Firebase("https://example.firebaseio.com/stuff");
  $scope.stuff = $firebase(oneRef);
  $scope.stuff.$on("loaded", function(value) {
    console.log(value);
  });
}])

.controller('twoCtrl', ["$scope", "$firebase", function($scope, $firebase) {

  var twoRef = new Firebase("https://example.firebaseio.com/stuff");
  $scope.stuff = $firebase(twoRef);
  $scope.stuff.$on("loaded", function(value) {
    console.log(value);
  });
}])

If a new ref was instantiated - twoRef - why doesn't the callback fire a second time?

Upvotes: 3

Views: 399

Answers (1)

Kato
Kato

Reputation: 40582

This is due to the fact that locally cached data fires value events synchronously in Firebase.

On the first load, the server is contacted asynchronously by angularFire's _getInitialValue method. However, on the second load, since the value is already local, the broadcast event happens synchronously, and therefore before your $on('loaded'...) handler gets attached.

A couple thoughts come to mind: If the controllers are utilizing the same $firebase data, there should probably--in most common use cases--only be one. It should be moved to a service and shared accordingly.

Another workaround would be to store the loaded state in a service or in the $rootScope.

Ultimately, it should be corrected in angularFire so that the loaded event triggers even if the 'value' is already loaded synchronously.

Upvotes: 3

Related Questions