CODEWITHSUNDEEP
linqnull
malik
malik

Reputation: 333

Linq error generic parameter or the query must use a nullable type

I got this error when i use sum function in LINQ:

The cast to value type 'Decimal' failed because the materialized value is null. Either the result type's generic parameter or the query must use a nullable type.

GroupProduct.Where(a => a.Product.ProductID==1).Sum(Content => Content.Amount==null?0:Content.Amount),

Upvotes: 16

Views: 23294

Answers (5)

mendel
mendel

Reputation: 1551

This is what I usually use. This will cover the possibility of Amount being null and also cover the possibility of an empty set.

GroupProduct.Where(a => a.Product.ProductID == 1)
    .Select(c => c.Amount ?? 0) // select only the amount field
    .DefaultIfEmpty()  // if selection result is empty, return the default value
    .Sum(c => c)

DefaultIfEmpty() returns the default value associated with Amount's type, which is int, in which case the default value is 0.

Upvotes: 15

amiry jd
amiry jd

Reputation: 27585

Try this:

var sum = GroupProduct.Where(a => a.Product.ProductID==1).Sum(Content => (int?) Content.Amount);
sum = sum ?? 0;

Upvotes: 4

Merenzo
Merenzo

Reputation: 5156

This looks like it should work (and usually does) but fails when the Where() method returns null: 

decimal sum1 = GroupProduct
    .Where(a => a.Product.ProductID == 1)
    .Sum(c => c.Amount ?? 0);

The error: "The cast to value type 'Decimal' failed because the materialized value is null" is due to the Sum() method returning null (not zero) when summing over an empty set.

Either of these work for me:

decimal? sum2 = GroupProduct
    .Where(a => a.Product.ProductID == 1)
    .Sum(c => c.Amount);

decimal sum3 = GroupProduct
    .Where(a => a.Product.ProductID == 1)
    .Sum(c => c.Amount) ?? 0;

Upvotes: 1

mattruma
mattruma

Reputation: 16677

Did you try the following:

GroupProduct.Where(a => a.Product.ProductID==1).Sum(Content => (decimal?)Content.Amount)

The code from my application looks like:

var data = query.AsEnumerable().Select(row => TaskInfo.FetchTaskInfo(row,
      ctx.ObjectContext.Hours.Where(hour => hour.TaskId == row.TaskId).Sum(hour => (decimal?)hour.Duration),
      ctx.ObjectContext.Notes.Count(note => note.SourceType == (int)SourceType.Task && note.SourceId == row.TaskId)));

Upvotes: 11

Marc Gravell
Marc Gravell

Reputation: 1062600

You could exclude at source?

var sum = GroupProduct.Where(a => a.Product.ProductID==1 && a.Amount != null)
            .Sum(a => (decimal)a.Amount);

Upvotes: 4

Related Questions