CODEWITHSUNDEEP
c#performancec#-4.0parallel-processingtask-parallel-library
xoyoja
xoyoja

Reputation: 436

Changing Parallel.ForEach to better approach

I use Task Parallel Library(TPL) and C# 4.5 to implement this business logic in a Windows Service Application:

Currently the problem is: It may take long time saving each item to database (Sync DAL), so Parallel.ForEach 1000 items takes forever and the Windows Service application appears slower and slower. Does anyone have good ideas or better approach to gain better performance?

Code snippet:

/* Download a list from RESTful API URL.... */
var task = Task.Factory.StartNew(() => { return DownloadListFromRestAPI(); }, TaskCreationOptions.LongRunning);
task.ContinueWith(i => {
     foreach (var r in i.Result)
      {
          /* For each item, download the item details from RESTful API URL.... */
           var taskSecond = Task.Factory.StartNew(() => { return DownloadItemDetailFromRestAPI(r.id); }, TaskCreationOptions.LongRunning);
           taskSecond.ContinueWith(m => {
               /* For each  item detail, get the related business objects, and start Database operation on each object.... */
                List<Item> relatedItems_1000 = s.GetRelatedObjectsIds(m.Result.id);

              /* parallel.ForEach - 1000 or more items  */
                 Parallel.ForEach<Item>(relatedItems_1000, new ParallelOptions { MaxDegreeOfParallelism = 8 }, d => DBLongProcess(d)); /* The DB operation takes long time */
          });
      }
 });

Update: (the code for DBLongProcess() and the lock (I added lock because concurrent threads may attempt to modify same object to DB))

 private void DBLongProcess(Item item)
 {
    dbDAL.InsertObjectDB(item));
 }

 public class DBDAL
 {
      private readonly object _lock = new object();

      public void InsertObjectDB(Item item)
      {
          lock (_lock)
          {
             if(!item.hasDetail1()){
                 //insert item.detail1...
             }
              if(!item.hasDetail2()){
                //insert item.detail2
             }
          }
      }
 }

Upvotes: 0

Views: 1214

Answers (1)

svick
svick

Reputation: 245046

In your case, using Parallel.ForEach() won't speed up anything, because the lock in InsertObjectDB() forces all items to be inserted in series.

What you need to do is to figure a way of making DBDAL thread-safe (possibly by using multiple instances of it). If that's not feasible, then you'll have to look for performance improvements elsewhere.

Upvotes: 3

Related Questions