CODEWITHSUNDEEP
linuxbash.htaccessshellsed
makki
makki

Reputation: 2107

use of sed substitute in shell script doesn't work

I have made an install script which basically inserts some RewriteRule right after RewriteEngine On line by using sed inside a shell script

#!/bin/bash

REWRITE_RULE="RewriteRule \^catalog\/category\/view\/id\/([0-9]+)$ http:\/\/localhost\/app\/#?c=$1 [NE,L,R=301]"
FILE_PATH=".htaccess"

sed -i "s/RewriteEngine on/RewriteEngine on\n\n$REWRITE_RULE/g" $FILE_PATH

it does nothing but gives some error like

: No such file or directory

I tried same commands in shell and it worked without any issues and updated my .htaccess file

I am new to shell scripting so don't know the difference of using same command through shell and through script.. please guide

Upvotes: 0

Views: 1021

Answers (2)

that other guy
that other guy

Reputation: 123490

You'll find that your script contains carriage returns due to being saved with DOS end-of-line characters. Use tr -d '\r' <brokenscript >fixedscript to fix your script.

Here's a copy of a session with the problem reproduced and fixed:

$ cat file
var=foo

$ cat myscript
sed -i s/foo/bar/ file

$ bash myscript
: No such file or directory

$ shellcheck myscript

In myscript line 1:
sed -i s/foo/bar/ file
                      ^-- SC1017: Literal carriage return. Run script through tr -d '\r' .

$ tr -d '\r' < myscript > fixedscript

$ bash fixedscript

$ cat file
var=bar

$

Upvotes: 1

Michael Schlottke-Lakemper
Michael Schlottke-Lakemper

Reputation: 9321

The script itself is fine. Are you sure that the lines posted above are exactly as you took them from your script?

The error message indicates that you provided an empty name as the filename, thus I suggest you put a

echo "FILE_PATH: $FILE_PATH"

directly before your sed command in order to check whether the variable is set correctly.

Upvotes: 2

Related Questions