CODEWITHSUNDEEP
c#validationtextbox
Kpt.Khaos
Kpt.Khaos

Reputation: 693

Performing multiple validations on one field C#

I have to validate the textboxes to check if they are a number and if they are in the database. Only problem is I can only seem to get it to check for validity or if they are numeric. How can change this to get both validations?

it validates to make sure there is something in the textboxes:

if (string.IsNullOrEmpty(employeeIDTextBox.Text) && (string.IsNullOrEmpty(JobIDTextBox.Text)))

Then it looks to see if the value is numeric, then if it does it checks to see if the person exists, then sets the values

else if (string.IsNullOrEmpty(JobIDTextBox.Text))
     {
        if (!Int32.TryParse(JobIDTextBox.Text, out number1))
        {
           using (dbConn)
           {
              ReportGrid newGrid = new ReportGrid();

              if (newGrid.isValidEmp(Int32TryParseSafe(employeeIDTextBox.Text)))
              {
                  newGrid.startDate = startingdateTimePicker.Value;
                  newGrid.endDate = endingdateTimePicker.Value;

                  newGrid.EmployeeID = Int32TryParseSafe(employeeIDTextBox.Text);
                  newGrid.JobID = Int32TryParseSafe(JobIDTextBox.Text);

                  newGrid.ShowDialog();
               }
               else
               {
                   MessageBox.Show("No ID found for the employee.", "Alert", MessageBoxButtons.OK, MessageBoxIcon.Warning);
                }

Then it does the same for the other textbox

else if (string.IsNullOrEmpty(employeeIDTextBox.Text))
      {
          if (!Int32.TryParse(emplyeeIDLabel.Text, out number2))
          {
             using (dbConn)
             {
                 ReportGrid newGrid = new ReportGrid();

                 if (newGrid.isValidJob(Int32TryParseSafe(JobIDTextBox.Text)))
                 {
                     newGrid.startDate = startingdateTimePicker.Value;
                     newGrid.endDate = endingdateTimePicker.Value;

                     newGrid.EmployeeID = Int32TryParseSafe(employeeIDTextBox.Text);
                     newGrid.JobID = Int32TryParseSafe(JobIDTextBox.Text);

                     newGrid.ShowDialog();
                   }

                   else
                   {
                      MessageBox.Show("No ID found for that job.", "Alert", MessageBoxButtons.OK, MessageBoxIcon.Warning);
                   }
                }
             }
             else
                MessageBox.Show("Must be a number.");
           }

Here is the whole code

try
{

    if (string.IsNullOrEmpty(employeeIDTextBox.Text) && (string.IsNullOrEmpty(JobIDTextBox.Text)))
    {
        MessageBox.Show("Please enter a EmployeeID or JobID.", "Alert", MessageBoxButtons.OK, MessageBoxIcon.Warning);
     }
     else if (string.IsNullOrEmpty(JobIDTextBox.Text))
     {
        if (!Int32.TryParse(JobIDTextBox.Text, out number1))
        {
           using (dbConn)
           {
              ReportGrid newGrid = new ReportGrid();

              if (newGrid.isValidEmp(Int32TryParseSafe(employeeIDTextBox.Text)))
              {
                  newGrid.startDate = startingdateTimePicker.Value;
                  newGrid.endDate = endingdateTimePicker.Value;

                  newGrid.EmployeeID = Int32TryParseSafe(employeeIDTextBox.Text);
                  newGrid.JobID = Int32TryParseSafe(JobIDTextBox.Text);

                  newGrid.ShowDialog();
               }
               else
               {
                   MessageBox.Show("No ID found for the employee.", "Alert", MessageBoxButtons.OK, MessageBoxIcon.Warning);
                }

             }
         }
         else
            MessageBox.Show("Must be a number.");

         if (startingdateTimePicker.Value > endingdateTimePicker.Value)
         {
             MessageBox.Show("Starting data can not be after than ending date.", "Alert", MessageBoxButtons.OK, MessageBoxIcon.Warning);
         }
      }
      else if (string.IsNullOrEmpty(employeeIDTextBox.Text))
      {
          if (!Int32.TryParse(emplyeeIDLabel.Text, out number2))
          {
             using (dbConn)
             {
                 ReportGrid newGrid = new ReportGrid();

                 if (newGrid.isValidJob(Int32TryParseSafe(JobIDTextBox.Text)))
                 {
                     newGrid.startDate = startingdateTimePicker.Value;
                     newGrid.endDate = endingdateTimePicker.Value;

                     newGrid.EmployeeID = Int32TryParseSafe(employeeIDTextBox.Text);
                     newGrid.JobID = Int32TryParseSafe(JobIDTextBox.Text);

                     newGrid.ShowDialog();
                   }

                   else
                   {
                      MessageBox.Show("No ID found for that job.", "Alert", MessageBoxButtons.OK, MessageBoxIcon.Warning);
                   }
                }
             }
             else
                MessageBox.Show("Must be a number.");
           }
        }
        catch (Exception ex)
        {
            MessageBox.Show(ex.ToString());
        }

Upvotes: 0

Views: 429

Answers (1)

runninbare
runninbare

Reputation: 34

I could be mistaken but is this line possibly the problem?

if (!Int32.TryParse(emplyeeIDLabel.Text, out number2))

The exclamation point reverses the bool so if the text successfully parses as a number the TryParse function returns true but by using the exclamation the if statement resolves to false. Therefore you are sending the code to else statement which states that it is not a number.

Also, try using "Return" to avoid nested ifs.

if (string.IsNullOrEmpty(employeeIDTextBox.Text) && (string.IsNullOrEmpty(JobIDTextBox.Text)))
{
    MessageBox.Show("Please enter a EmployeeID or JobID.", "Alert", MessageBoxButtons.OK, MessageBoxIcon.Warning);
    Return;
 }

There's no need for an else at this point because the if the if statement resolves to true you will return from the method.

Nested if statements are frequently necessary but they should be avoided when they can to make code clearer to read for maintenance.

Upvotes: 1

Related Questions