CODEWITHSUNDEEP
phpmysqlcount
user3109875
user3109875

Reputation: 828

PHP pagination, only count rows from where column is not empty

I'm using the following code to show some pages of data, but now i don't want to display empty pages whereas the data is somewhere in page 12 while page 1 is empty.

So the problem seems to be in this block of code.

//$sql = "SELECT COUNT(*) FROM ads";
$sql = "SELECT COUNT(*) FROM ads WHERE position IS NOT NULL or position != ''";
$result = mysql_query($sql, $con) or trigger_error("SQL", E_USER_ERROR);
$r = mysql_fetch_row($result);
$numrows = $r[0];
// number of rows to show per page
$rowsperpage = 20;
// find out total pages
$totalpages = ceil($numrows / $rowsperpage);

and here's the full code.

$sql = "SELECT COUNT(*) FROM ads WHERE position IS NOT NULL or position != ''";
$result = mysql_query($sql, $con) or trigger_error("SQL", E_USER_ERROR);
$r = mysql_fetch_row($result);
$numrows = $r[0];
$rowsperpage = 20;
$totalpages = ceil($numrows / $rowsperpage);

// get the current page or set a default
if (isset($_GET['currentpage']) && is_numeric($_GET['currentpage'])) {
   // cast var as int
   $currentpage = (int) $_GET['currentpage'];
} else {
   // default page num
   $currentpage = 1;
} // end if

// if current page is greater than total pages...
if ($currentpage > $totalpages) {
   // set current page to last page
   $currentpage = $totalpages;
} // end if
// if current page is less than first page...
if ($currentpage < 1) {
   // set current page to first page
   $currentpage = 1;
} // end if

// the offset of the list, based on current page 
$offset = ($currentpage - 1) * $rowsperpage;

// get the info from the db 
$sql = "SELECT * FROM ads LIMIT $offset, $rowsperpage";
$result = mysql_query($sql, $con) or trigger_error("SQL", E_USER_ERROR);
//require 'carrer_ad.php';

// while there are rows to be fetched...
while ($row = mysql_fetch_assoc($result)) {
   // echo data
   //echo $list['name'] . "<br />";
   require 'carrer_ad.php';
$adCondition = (!empty($row['position'])) ? $ad : '';   
echo $adCondition;
} // end while

/******  build the pagination links ******/
// range of num links to show
$range = 3;

// if not on page 1, don't show back links
if ($currentpage > 1) {
   // show << link to go back to page 1
   echo " <a href='{$_SERVER['PHP_SELF']}?currentpage=1'><<</a> ";
   // get previous page num
   $prevpage = $currentpage - 1;
   // show < link to go back to 1 page
   echo " <a href='{$_SERVER['PHP_SELF']}?currentpage=$prevpage'><</a> ";
} // end if 

// loop to show links to range of pages around current page
for ($x = ($currentpage - $range); $x < (($currentpage + $range) + 1); $x++) {
   // if it's a valid page number...
   if (($x > 0) && ($x <= $totalpages)) {
      // if we're on current page...
      if ($x == $currentpage) {
         // 'highlight' it but don't make a link
         echo " [<b>$x</b>] ";
      // if not current page...
      } else {
         // make it a link
         echo " <a href='{$_SERVER['PHP_SELF']}?currentpage=$x'>$x</a> ";
      } // end else
   } // end if 
} // end for

// if not on last page, show forward and last page links        
if ($currentpage != $totalpages) {
   // get next page
   $nextpage = $currentpage + 1;
    // echo forward link for next page 
   echo " <a href='{$_SERVER['PHP_SELF']}?currentpage=$nextpage'>></a> ";
   // echo forward link for lastpage
   echo " <a href='{$_SERVER['PHP_SELF']}?currentpage=$totalpages'>>></a> ";
}

Upvotes: 1

Views: 545

Answers (2)

CyberGuru
CyberGuru

Reputation: 55

try changing your query to: 

$sql = "SELECT COUNT(*) FROM ads WHERE position IS NOT NULL and position <> ''";

Upvotes: 1

user1844933
user1844933

Reputation: 3417

Try this

if ($currentpage >= $totalpages) {
       // set current page to last page
       $currentpage = $totalpages;
    } // end if
    // if current page is less than first page...
    if ($currentpage <= 1) {
       // set current page to first page
       $currentpage = 1;
    } // end if

Upvotes: 1

Related Questions