CODEWITHSUNDEEP
javascriptimagecanvas
user3174547
user3174547

Reputation: 7

Moving an image on a javascript canvas

I'm trying to get a very simple animation to work where a image loaded onto a Javascript Canvas just slides to the right. The following code works with a rectangle drawn but when I try to insert the image nothing loads but I get no error messages. I need to get it working with only Javascript.

window.requestAnimFrame = (function(){
  return  window.requestAnimationFrame       ||
          window.webkitRequestAnimationFrame ||
          window.mozRequestAnimationFrame    ||
          window.oRequestAnimationFrame      ||
          window.msRequestAnimationFrame     ||
          function( callback ){
            window.setTimeout(callback, 1000 / 60);
          };
})();

var canvas = document.getElementById("canvas"),
    cx = canvas.getContext("2d");

function Card(x,y){
  this.x = x || 0;
  this.y = y || 0;


  this.draw = function(){
    var img = new Image();
    img.onload = function() 
    {
        cx.drawImage(img, x, y);
    }
    img.src = "images/back.jpg";
  }
}

var myCard = new Card(50,50);

function loop(){
  cx.clearRect(0, 0, canvas.width, canvas.height);

  myCard.x++;

  myCard.draw();

  requestAnimFrame(loop);
}
loop();

Upvotes: 0

Views: 1397

Answers (1)

markE
markE

Reputation: 105035

Problem is that your [x,y] values are undefined in your draw function.

Demo: http://jsfiddle.net/m1erickson/qAm39/

Here's a refactoring of your code to keep things in proper scope:

<!doctype html>
<html>
<head>
<link rel="stylesheet" type="text/css" media="all" href="css/reset.css" /> <!-- reset css -->
<script type="text/javascript" src="http://code.jquery.com/jquery.min.js"></script>

<style>
    body{ background-color: ivory; }
    #canvas{border:1px solid red;}
</style>

<script>
$(function(){


    window.requestAnimFrame = (function(){
      return  window.requestAnimationFrame       ||
              window.webkitRequestAnimationFrame ||
              window.mozRequestAnimationFrame    ||
              window.oRequestAnimationFrame      ||
              window.msRequestAnimationFrame     ||
              function( callback ){
                window.setTimeout(callback, 1000 / 60);
              };
    })();

    var canvas = document.getElementById("canvas"),
        cx = canvas.getContext("2d");

    function Card(x,y){
      this.x = x || 0;
      this.y = y || 0;
      this.img=new Image();

      this.init=function(){

        // "var self=this" makes myCard available in the img.onload function
        // otherwise "this" inside img.onload refers to the img
        var self=this;

        this.img.onload = function() 
        {
            self.draw();
            loop();
        }
        this.img.src = "https://dl.dropboxusercontent.com/u/139992952/stackoverflow/house16x16.png";  
      }

      // x,y need to be this.x and this.y

      this.draw = function(){
        cx.drawImage(this.img, this.x, this.y);
      }

    }

    var myCard = new Card(50,50);
    myCard.init();

    function loop(){

      if(myCard.x<canvas.width-20){
          requestAnimFrame(loop);
      }

      cx.clearRect(0, 0, canvas.width, canvas.height);

      myCard.x++;

      myCard.draw();

    }


}); // end $(function(){});
</script>

</head>

<body>
    <canvas id="canvas" width=300 height=300></canvas>
</body>
</html>

Upvotes: 1

Related Questions