CODEWITHSUNDEEP
pythonbinary-search-tree
python-coder
python-coder

Reputation: 2148

how to calculate the height of a BST in python

I've created a BST. and now I want to find the height of the BST developed.

Here is my code for constructing the BST

class Node:
    '''represents a new node in the BST'''
    def __init__(self,key):
        self.key=key
        self.disconnect()
    def disconnect(self):
        self.left=None;
        self.right=None;
        self.parent=None;
    def __str__(self):
        return 'node with kay %s'%self.key

class BST:
    def __init__(self):
        self.root=None

    def insert(self,t):
        '''inserts a new element into the tree'''
        if self.root is None:
            self.root = Node(t)
        else:
            self._do_insert(self.root,t)

    def _do_insert(self,parent,t):
        if t > parent.key:
            if parent.left is None:
                parent.left = Node(t)
            else:
                self._do_insert(parent.left,t)
        elif t < parent.key:
            if parent.right is None:
                parent.right = Node(t)
            else:
                self._do_insert(parent.right,t)
        else:
            # raise a KeyError or something appropriate?
            pass

I've a list of numbers ([2,4,6,3,190,1,56 and so on]) via which this BST is constructed.

Now I want to find the height of the BST created. How can I do that?

EDIT

As per the solution provided I tried this :-

def create_bst(values):

    '''Creates a BST and returns the BST created object'''
    BSTobj = BST()

    for i in values:
        BSTobj.insert(i)

    return BSTobj


def height_of_BST(bst):

    '''Returns the height of the BST created'''
    if bst == None: return 0
    else: return 1 + max(height_of_BST(bst.left), height_of_BST(bst.right))


print height_of_BST(create_bst(unique_values))

And its not working. It pops up an error saying BST instance has no attribute 'left'

Upvotes: 2

Views: 16970

Answers (4)

thierno
thierno

Reputation: 934

The interpreter is complaining because you didn't check for cases where the node has no children. If a node has no children it heigth is -1 here a solution

def height(bst): if bst == None : return -1 else: return 1 + max(height(bst.left), height(bst.right))

Upvotes: 0

narfeta
narfeta

Reputation: 1

You can use hasattr to check if the object has the attr, if not you get to the end of the tree

def height(bst_node):
     if not hasattr(bst_node, 'left') or not hasattr(bst_node, 'right'):
         return 0
    else:
        return 1 + max(height(bst_node.left), height(bst_node.right))

Upvotes: -1

reem
reem

Reputation: 7236

The BST in your class is actually stored in BST.root not in BST. You need to modify your code to look at BST.root instead of BST.

Try:

def height(BST):
    return actual_height(BST.root)
def actual_height(bst_node):
    if bst_node is None:
        return 0
    else:
        return 1 + max(actual_height(bst_node.left), actual_height(bst_node.right))

This defines a helper function that does the actual work but lets you just call height on the BST object. In the future, you might just want to only have a Node class because your BST class is basically just a wrapper around the root value.

Upvotes: 1

user2357112
user2357112

Reputation: 280778

The height of a nonempty binary search tree is 1 + the height of its tallest subtree, or just 1 if it has no children. This translates pretty directly to a recursive algorithm. In pseudocode:

def height(bst):
    if isempty(bst):
        return 0
    else:
        return 1 + max(height(bst.left), height(bst.right))

Upvotes: 11

Related Questions