CODEWITHSUNDEEP
androidaudiosoundpool
Always Newbie
Always Newbie

Reputation: 43

SoundPool not Playing?

I have 2 SoundPool instances and if I run my application, soundPool2 is running the same sound with soundPool1, I don't know why this play same sound. Can anyone help me find the problem?

public class MainActivity extends Activity implements OnTouchListener {
private SoundPool soundPool;
private SoundPool soundPool2;
private int soundID;
private int soundID2;
boolean loaded = true;

/** Called when the activity is first created. */
@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    View view = findViewById(R.id.button1);
    view.setOnTouchListener(this);

    // Set the hardware buttons to control the music
    this.setVolumeControlStream(AudioManager.STREAM_MUSIC);
    // Load the sound
    soundPool = new SoundPool(10, AudioManager.STREAM_MUSIC, 0);
    soundPool.setOnLoadCompleteListener(new OnLoadCompleteListener()
    {
        @Override
        public void onLoadComplete(SoundPool soundPool, int sampleId,
                int status) {
            loaded = true;
        }
    });

    soundID = soundPool.load(this, R.raw.sound1, 1);

    View view2 = findViewById(R.id.button2);
    view2.setOnTouchListener(this);
    this.setVolumeControlStream(AudioManager.STREAM_MUSIC);
    soundPool2 = new SoundPool(10, AudioManager.STREAM_MUSIC, 0);
    soundPool2.setOnLoadCompleteListener(new OnLoadCompleteListener()
    {
        @Override
        public void onLoadComplete(SoundPool soundPool2, int sampleId,
                int status) {
            loaded = true;


        }
    });


    soundID2 = soundPool.load(this, R.raw.bird, 1);

}

public boolean onTouch( View v, MotionEvent event) {
    if (event.getAction() == MotionEvent.ACTION_DOWN) {
        // Getting the user sound settings
        AudioManager audioManager = (AudioManager) getSystemService(AUDIO_SERVICE);
        float actualVolume = (float) audioManager
                .getStreamVolume(AudioManager.STREAM_MUSIC);
        float maxVolume = (float) audioManager
                .getStreamMaxVolume(AudioManager.STREAM_MUSIC);
        float volume = actualVolume / maxVolume;
        // Is the sound loaded already?
        if (loaded) {
            soundPool.play(soundID, volume, volume, 1, 0, 1f);
            Log.e("Test", "Played ");
        }
    }
    return false;
}

public boolean onTouch2( View v, MotionEvent event) {
if (event.getAction() == MotionEvent.ACTION_DOWN) {
    // Getting the user sound settings
    AudioManager audioManager = (AudioManager) getSystemService(AUDIO_SERVICE);
    float actualVolume = (float) audioManager
            .getStreamVolume(AudioManager.STREAM_MUSIC);
    float maxVolume = (float) audioManager
            .getStreamMaxVolume(AudioManager.STREAM_MUSIC);
    float volume = actualVolume / maxVolume;
    // Is the sound loaded already?
    if (loaded) {
        soundPool2.play(soundID2, volume, volume, 1, 0, 1f);
        Log.e("Test", "Played sound");
    }
}
return false;
}}

Upvotes: 1

Views: 4870

Answers (1)

Tigger
Tigger

Reputation: 9120

First up, you only need a single instance of SoundPool, not two.

Also, your onTouch and onTouch2 does not make much sense to me, there could also be an issue there, so I re-wrote that part too.

Try the following code instead.

public class MainActivity extends Activity implements OnTouchListener {
    private SoundPool mSoundPool;
    private int mSoundID;
    private int mSoundID2;
    private boolean mSoundLoaded = false;
    private float mVolume = 0f;

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        setContentView(R.layout.activity_main);

        View view = findViewById(R.id.button1);
        view.setOnTouchListener(this);
        View view2 = findViewById(R.id.button2);
        view2.setOnTouchListener(this);

        // Set the hardware buttons to control the music
        this.setVolumeControlStream(AudioManager.STREAM_MUSIC);

        // Load the sound
        mSoundPool = new SoundPool(10, AudioManager.STREAM_MUSIC, 0);
        mSoundPool.setOnLoadCompleteListener(new OnLoadCompleteListener() {
            @Override
            public void onLoadComplete(SoundPool soundPool, int sampleId, int status) {
                if (sampleId == R.raw.bird) {
                    mSoundLoaded = true;
                }
            }
        });

        mSoundID = mSoundPool.load(this, R.raw.sound1, 1);
        mSoundID2 = mSoundPool.load(this, R.raw.bird, 1);

        // Getting the user sound settings
        AudioManager audioManager = (AudioManager) getSystemService(AUDIO_SERVICE);
        float actualVolume = (float) audioManager
                .getStreamVolume(AudioManager.STREAM_MUSIC);
        float maxVolume = (float) audioManager
                .getStreamMaxVolume(AudioManager.STREAM_MUSIC);
        mVolume = actualVolume / maxVolume;
    }

    public boolean onTouch(View v, MotionEvent event) {
        if (event.getAction() == MotionEvent.ACTION_DOWN) {
            // Is the sound loaded already?
            if (mSoundLoaded) {
                if (v.getId() == R.id.button1) {
                    playSound(mSoundID);
                    Log.e("Test", "Played mSoundID");
                } else if (v.getId() == R.id.button2) {
                    playSound(mSoundID2);
                    Log.e("Test", "Played mSoundID2");
                }
            }
        }
        return false;
    }

    private void playSound(int soundId) {
        mSoundPool.play(soundId, mVolume, mVolume, 1, 0, 1f);
    }
}

NOTE: There may be errors, it is untested code.

Upvotes: 4

Related Questions