Reputation: 2064
I am implementing swipe action in my code to change background images. But when I run my app its crash. I dont know whats wrong in my code.
Code-
public class Types extends Activity{
RelativeLayout layout1;
int[] backgroundResId;
int currentIndex=0;
@Override
public void onCreate(Bundle savedInstanceState)
{
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_type);
backgroundResId=new int[]{R.drawable.back,R.drawable.bg,R.drawable.frame1};
changeBackground();
ActivitySwipeDetector activitySwipeDetector = new ActivitySwipeDetector(this);
layout1.setOnTouchListener(activitySwipeDetector);
}
private void changeBackground(){
findViewById(R.id.layout1).setBackgroundResource(backgroundResId[currentIndex]);
}
public class ActivitySwipeDetector implements View.OnTouchListener {
static final String logTag = "ActivitySwipeDetector";
static final int MIN_DISTANCE = 100;
private float downX, upX;
private Activity activity;
public ActivitySwipeDetector(Activity activity){
this.activity = activity;
}
public void onRightToLeftSwipe(){
Log.i(logTag, "RightToLeftSwipe!");
currentIndex++;
if(currentIndex<backgroundResId.length){
changeBackground();
}
}
public void onLeftToRightSwipe(){
Log.i(logTag, "LeftToRightSwipe!");
if(currentIndex>0){
changeBackground();
}
}
public boolean onTouch(View v, MotionEvent event) {
switch(event.getAction()){
case MotionEvent.ACTION_DOWN: {
downX = event.getX();
return true;
}
case MotionEvent.ACTION_UP: {
upX = event.getX();
float deltaX = downX - upX;
// swipe horizontal?
if(Math.abs(deltaX) > MIN_DISTANCE){
// left or right
if(deltaX < 0) { this.onLeftToRightSwipe(); return true; }
if(deltaX > 0) { this.onRightToLeftSwipe(); return true; }
}
else {
Log.i(logTag, "Swipe was only " + Math.abs(deltaX) + " long, need at least " + MIN_DISTANCE);
return false; // We don't consume the event
}
return true;
}
}
return false;
}
}
}
Upvotes: 1
Views: 186
Reputation: 1422
You must be getting the NullPointerException, because you haven't initialized the RelativeLayout instance layout1. Do it like this-
private void changeBackground()
{
layout1 = findViewById(R.id.layout1);
layout1.setBackgroundResource(backgroundResId[currentIndex]);
}
Upvotes: 0
Reputation: 1532
RelativeLayout layout1;
You have declared but didn't initialize the layout1, initialize it with the id and try.
Upvotes: 3