CODEWITHSUNDEEP
javaspringtransactions
Igor Konoplyanko
Igor Konoplyanko

Reputation: 9374

Spring transaction: rollback on Exception or Throwable

I wonder whether it makes sense to use instead of 

@Transactional(propagation = Propagation.REQUIRED, rollbackFor = Exception.class)

to use Throwable

@Transactional(propagation = Propagation.REQUIRED, rollbackFor = Throwable.class)

As I understand catching Error will help us behave correctly even when something really bad happen. Or maybe it wouldn't help?

Upvotes: 45

Views: 126094

Answers (4)

René Link
René Link

Reputation: 51483

As I understand catching Error will help us behave correctly even when something really bad happen. Or maybe it wouldn't help?

You don't need to explicitly specify rollbackFor = Throwable.class, because Spring will by default rollback the transaction if an Error occurs.

See 1.4.3. Rolling Back a Declarative Transaction

In its default configuration, the Spring Framework’s transaction infrastructure code marks a transaction for rollback only in the case of runtime, unchecked exceptions. That is, when the thrown exception is an instance or subclass of RuntimeException. (Error instances also, by default, result in a rollback). Checked exceptions that are thrown from a transactional method do not result in rollback in the default configuration.

Or take a look at the DefaultTransactionAttribute

public boolean rollbackOn(Throwable ex) {
    return (ex instanceof RuntimeException || ex instanceof Error);
}

Upvotes: 65

Sotirios Delimanolis
Sotirios Delimanolis

Reputation: 280179

Since you are using @Transactional, we can safely assume you are doing your database operations through Spring, Hibernate, or other JDBC wrappers. These JDBC wrappers don't typically throw checked exceptions, they throw runtime exceptions that wrap the JDBC SQLException types.

@Transactional is setup to rollback, by default, only when an unchecked exception is thrown.

Consider a use case like so

@Transactional
public void persistAndWrite(Bean someBean) throws IOException {
    // DB operation
    getSession().save(someBean); 

    // File IO operation which throws IOException
    someFileService.writeToFile(someBean); 
}

You wouldn't necessarily want to rollback the DB operation just because we couldn't write something to a file.

Similarly

@Transactional
public void persistAndThrowOutOfMemory(Bean someBean)  {
    // DB operation
    getSession().save(someBean);

    // consumes all memory, throws OutOfMemoryError
    someService.hugeOperationThrowsOutOfMemoryError(); 
}

You wouldn't necessarily want to rollback the saved entity just because some service cause too much memory to be consumed.

@Transactional gives you the option. Use it where appropriate.

Upvotes: 18

Ali.Mojtahed
Ali.Mojtahed

Reputation: 2587

Default value of rollback is register on Error Exception but when u register try{}catch{} manually it overriding the error, so in this case use 

catch {
        TransactionAspectSupport.currentTransactionStatus().setRollbackOnly();
      }

to do it manually or remove try catch

also you may register exception type in transactional annotation such:

@Transactional(propagation = Propagation.REQUIRED, rollbackFor = Exception.class)

Upvotes: 2

Arsen Alexanyan
Arsen Alexanyan

Reputation: 3141

I don't know is it possible or not but handling Throwables like Errors is a bad style of programming, it is not the developers responsibility to handle this kind of fatal errors. There always can happen bad things which You cannot handle. You should handle checked exceptions if necessary, which are known to your system like some type of logical errors.

Upvotes: 0

Related Questions