CODEWITHSUNDEEP
angularjs
nwilliams36
nwilliams36

Reputation: 201

Angular factory with parameters

I have a small factory which requests data from a database (through php pages which return json objects). However to do this I need to set certain parameters in the get request. I have created a factory object to make the request.

app.factory('getplayerfactory', function($http){
return{
        getPlayer: function(callback, name, currentinnings) {
            var file = "/ajax.php?file=getplayer&displayname="+name+"&currentinnings="+currentinnings
            $http.get(file).success(callback)
        }
    }
})// end of getplayersfactory

(I am using npm coding standard so no semi colons at the end of lines)

In my controller I want to call this factory and then use the results to fill data. I have tried to use the following to call this

getplayerfactory.getPlayer(function(results, "M. Millent", 1){
    $scope.players[0].setHowout(results.howout)
})

However this creates an error when I introduce more parameters than results. I have used this factory pattern with other $http data request where the get request does not need parameters which works fine.

How do I make a get request which sets parameters? or do I need to create a separate factory for each set of parameters?

Upvotes: 1

Views: 310

Answers (1)

Ilan Frumer
Ilan Frumer

Reputation: 32367

function(results, "M. Millent", 1) { is not a valid function signature

I think this is what you meant:

getplayerfactory.getPlayer(function(results){
    $scope.players[0].setHowout(results.howout)
}, "M. Millent", 1)

Upvotes: 1

Related Questions