Looking to create a generic variable (i hope that is the right term)

Question

I am looking to make a few changes so that I do not have to repeat my code (makes sense)!

Here is what I have as of right now:

package com.rcd.learningactivities;

import java.text.DecimalFormat;
import java.util.concurrent.TimeUnit;

import android.app.Activity;
import android.os.Bundle;
import android.os.CountDownTimer;
import android.view.Menu;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.TextView;

public class MainActivity extends Activity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);


        final TextView blueTimer = (TextView) findViewById(R.id.blueTimer);  
        Button blue = (Button) findViewById(R.id.button1);

        final TextView redTimer = (TextView) findViewById(R.id.redTimer);  
        Button red = (Button) findViewById(R.id.button2);



        final CountDownTimer cd = new CountDownTimer(300000, 1000) {

             public void onTick(long millisUntilFinished) {
                    DecimalFormat dfmin = new DecimalFormat("0");
                    DecimalFormat dfsec = new DecimalFormat("00");
                    double seconds = TimeUnit.MILLISECONDS.toSeconds(millisUntilFinished)%60;
                    double min = TimeUnit.MILLISECONDS.toMinutes(millisUntilFinished);
                    blueTimer.setText(String.valueOf(dfmin.format(min)) + ":" + String.valueOf(dfsec.format(seconds)));

             }

             public void onFinish() {
                 blueTimer.setText("5:00");
             }
          };

        blue.setOnClickListener(new OnClickListener() {

            @Override
            public void onClick(View v) {
                if (blueTimer.getText().toString().contains("5:00")){
                    cd.start();

                } else {
                    cd.cancel();
                    cd.onFinish();
                }

            }
        });

        red.setOnClickListener(new OnClickListener() {

            @Override
            public void onClick(View v) {
                if (redTimer.getText().toString().contains("5:00")){
                    cd.start();
                } else {
                    cd.cancel();
                    cd.onFinish();
                }

            }
        });
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }

}

I would like both blue.setOnClickListener and red.setOnClickListener to be able to utilize my cd CountDownTimer however i need the blueTimer.setText(String...) to be able to change to redTimer.setText(String...) base on whichever button the user clicks.

I really hope this makes sense, and if I am thinking about this backwards, please let me know.

Essentially I want to make blueTimer in the onTick method above, variable x.

Answer 1

The simplest answer is to set which TextView you want updated in the timer, then start the timer. This would require you to extend CountDownTimer with your own class:

public class MyCountDownTimer extends CountDownTimer {

    private TextView viewToUpdate; 

    public void onTick(long millisUntilFinished) {
        DecimalFormat dfmin = new DecimalFormat("0");
        DecimalFormat dfsec = new DecimalFormat("00");
        double seconds = TimeUnit.MILLISECONDS.toSeconds(millisUntilFinished)%60;
        double min = TimeUnit.MILLISECONDS.toMinutes(millisUntilFinished);

        // Make sure a view has been set
        if (viewToUpdate != null) {
            viewToUpdate.setText(String.valueOf(dfmin.format(min)) + ":" + 
                                 String.valueOf(dfsec.format(seconds)));
        }   
     }

     public void onFinish() {
         if (viewToUpdate != null) {
             viewToUpdate.setText("5:00");
         }
     }

     public void setViewToUpdate(TextView v)
     {
         viewToUpdate = v;
     }
}

Now you can use that instead of CountDownTimer and in your click listeners you'd call setViewToUpdate() before calling start()

Answer 2

OnClickListener clickListener = new OnClickListener() {
    @Override
    public void onClick(View v) {

        TextView tv = null;
        switch(v.getId()){
          case R.id.button1:
              tv = blueTimer;
            break;
          case R.id.button2:
               tv = redTimer;
             break;
}
            if (tv.getText().toString().contains("5:00") {
                cd.start();
            } else {
                cd.cancel();
                cd.onFinish();
            }
        }
    }

blue.setOnClickListener(clickListener);
red.setOnClickListener(clickListener);

Answer 3

the point is to use class fields or properties:

    public class MainActivity extends Activity {
    protected CountDownTimer cd;
    private Button lastPressedButton;
    private Button red;
    private Button blue;
    private TextView blueTimer;
    private TextView redTimer;
        @Override
        protected void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_main);


            blueTimer = (TextView) findViewById(R.id.blueTimer);  
            blue = (Button) findViewById(R.id.button1);

            redTimer = (TextView) findViewById(R.id.redTimer);  
            red = (Button) findViewById(R.id.button2);



            cd = new CountDownTimer(300000, 1000) {

                 public void onTick(long millisUntilFinished) {
                        DecimalFormat dfmin = new DecimalFormat("0");
                        DecimalFormat dfsec = new DecimalFormat("00");
                        double seconds = TimeUnit.MILLISECONDS.toSeconds(millisUntilFinished)%60;
                        double min = TimeUnit.MILLISECONDS.toMinutes(millisUntilFinished);
if (lastPressedButton == red){
                 redTimer.setText(String.valueOf(dfmin.format(min)) + ":" + String.valueOf(dfsec.format(seconds)));
}
else if (lastPressedButton == blue){
                 blueTimer.setText(String.valueOf(dfmin.format(min)) + ":" + String.valueOf(dfsec.format(seconds)));
}


                 }

                 public void onFinish() {
    if (lastPressedButton == red)
                     blueTimer.setText("5:00");
    else if (lastPressedButton == blue){
    //something else?
    }
                 }
              };

            blue.setOnClickListener(new OnClickListener() {

                @Override
                public void onClick(View v) {
    lastPressedButton = blue;
                    if (blueTimer.getText().toString().contains("5:00")){
                        cd.start();

                    } else {
                        cd.cancel();
                        cd.onFinish();
                    }

                }
            });

            red.setOnClickListener(new OnClickListener() {

                @Override
                public void onClick(View v) {
    lastPressedButton = red;
                    if (redTimer.getText().toString().contains("5:00")){
                        cd.start();
                    } else {
                        cd.cancel();
                        cd.onFinish();
                    }

                }
            });
        }

        @Override
        public boolean onCreateOptionsMenu(Menu menu) {
            // Inflate the menu; this adds items to the action bar if it is present.
            getMenuInflater().inflate(R.menu.main, menu);
            return true;
        }

    }