Several PrimeFaces dialogs show up on validation error instead of single

Question

I have JSF and PrimeFaces 3.5 web application. Page home.xhtml contains a tabView component with 3 nested dataTables and buttons that perform add/edit/delete operations.

Every button calls a p:dialog with different form. Whenever one of the dialogs get validation error, all other dialogs are displayed too because their attribute is visible="#{facesContext.validationFailed}" (IMHO)

I need to display only one dialog which failed to validate untill user enters valid values or presses Cancel button (clears dialog form values).

Please, point me to the solution. I have spent over 20 hours trying. Every answer is highly appreciated.

Thank you.

home.xhtml:

HomeBean.java:

package com.infostroy.adminportal.controller.bean;

import com.infostroy.adminportal.bean.BaseBean;
import com.infostroy.adminportal.model.Application;
import com.infostroy.adminportal.model.Computer;
import com.infostroy.adminportal.model.User;
import com.infostroy.adminportal.service.HibernateDBManager;
import java.io.IOException;
import java.math.BigInteger;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
import java.util.List;
import org.primefaces.context.RequestContext;
import org.primefaces.event.SelectEvent;
import org.primefaces.event.UnselectEvent;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.context.annotation.Scope;
import org.springframework.stereotype.Component;

@Component
@Scope("session")
public class HomeBean extends BaseBean {

    private static final String editUserBtn = "tab:form1:editUser";
    private static final String deleteUserBtn = "tab:form1:deleteUser";
    private static final String editCompBtn = "tab:form2:editComp";
    private static final String deleteCompBtn = "tab:form2:deleteComp";
    private static final String editAppBtn = "tab:form3:editApp";
    private static final String deleteAppBtn = "tab:form3:deleteApp";
    @Autowired
    private HibernateDBManager hibernateDBManager;
    private List users;
    private List computers;
    private List applications;
    private User selectedUser, newUser;
    private Computer selectedComputer, newComputer;
    private Application selectedApplication, newApplication;
    private RequestContext rc;


    @Override
    public void init() {
        setUsers(hibernateDBManager.getAllUsers());
        setComputers(hibernateDBManager.getAllComputers());
        setApplications(hibernateDBManager.getAllApplications());
        newUser = new User();
        newComputer = new Computer();
        newApplication = new Application();
        rc = RequestContext.getCurrentInstance();
    }

    public void addUser() throws NoSuchAlgorithmException {
        if (newUser != null && newUser.getPassword() != null) {
            MessageDigest md = MessageDigest.getInstance("MD5");
            md.update(newUser.getPassword().getBytes());
            String hash = new BigInteger(1, md.digest()).toString(16);
            newUser.setPassword(hash);
            if (hibernateDBManager.insertUser(newUser)) {
                users.add(newUser);
            }
        }
    }

    public void deleteUser() throws IOException {
        if (selectedUser != null) {
            if (hibernateDBManager.deleteUserById(selectedUser.getUserId()) > 0) {
                users.remove(selectedUser);
                selectedUser = null;
                rc.update(deleteUserBtn);
                rc.update(editUserBtn);
            }
        }
    }

    public void addComputer() {
        if (newComputer != null && hibernateDBManager.insertComputer(newComputer)) {
            computers.add(newComputer);
        }
    }

    public void deleteComputer() {
        if (selectedComputer != null) {
            if (hibernateDBManager.deleteComputerById(selectedComputer.getComputerId()) > 0) {
                computers.remove(selectedComputer);
                selectedComputer = null;
                rc.update(editCompBtn);
                rc.update(deleteCompBtn);
            }
        }
    }

    public void addApplication() {
        if (newApplication != null && hibernateDBManager.insertApplication(newApplication)) {
            applications.add(newApplication);
        }
    }

    public void deleteApplication() {
        if (selectedApplication != null) {
            if (hibernateDBManager.deleteApplicationById(selectedApplication.getAppId()) > 0) {
                applications.remove(selectedApplication);
                selectedApplication = null;
                rc.update(editAppBtn);
                rc.update(deleteAppBtn);
            }
        }
    }


    public void onUserRowSelect(SelectEvent event) {
        setSelectedUser((User) event.getObject());
    }

    public void onUserRowUnselect(UnselectEvent event) {
        setSelectedUser(null);
    }

    public void onCompRowSelect(SelectEvent event) {
        setSelectedComputer((Computer) event.getObject());
    }

    public void onAppRowSelect(SelectEvent event) {
        setSelectedApplication((Application) event.getObject());
    }

//GETTERS/SETTERS

}

Manuel · Accepted Answer

If you want to validate multiple fields within a single method, you could do the following:

Variant 1:

Remove the visible="#{facesContext.validationFailed}" from your dialogs.
Remove the required=true from your dialogs fields.
Change the button (to all of them, just an example) from your dialogs from

to

and take care of closing the dialog within the homeBean's addComputer method:

public String addComputer() {
  // do some checks
  if (everythingIsOk) {
    RequestContext.getCurrentInstance().execute("dlg3.hide();");
  }
}

Variant 2:

If you don't want to do multiple checks within the addComputer method, you could use @Validators, see a Primefaces Showcase. There you can control the visibility of the dialogs within the validate(FacesContext context, UIComponent component, Object value) throws ValidatorException method.

The first method groups the validation into one place. The second variante is convenient because you can reuse the Validator classes.

Several PrimeFaces dialogs show up on validation error instead of single

Answers (1)

Related Questions