CODEWITHSUNDEEP
javasqldatabasesql-delete
user3268379
user3268379

Reputation: 141

Java sql delete row

Hello I am trying to delete a row from my database. I am getting no errors but it is doing nothing, any help or advice would be great!

public static void DeleteRow(String name) {
    try {  
        Class.forName("com.mysql.jdbc.Driver");
        Connection connection = DriverManager.getConnection(url, username, password);

        PreparedStatement st = connection.prepareStatement("DELETE FROM Table WHERE name = " + name + ";");
        st.executeUpdate();
    } catch(Exception e) {
        System.out.println(e);
    }
}

Upvotes: 10

Views: 80651

Answers (6)

SpringLearner
SpringLearner

Reputation: 13844

I guess name is a varchar type in DB so do like this 

PreparedStatement st = connection.prepareStatement("DELETE FROM Table WHERE name = '" + name + "';");

enclose name within single quotes '

Also this is not the way you are using is not the proper way of using Preparedstatement

Us the following way:

PreparedStatement st = connection.prepareStatement("DELETE FROM Table WHERE name = ?");
st.setString(1,name);
st.executeUpdate(); 

// your full code after Proper PreparedStatement

public static void DeleteRow(String name) {
    try {  
        Class.forName("com.mysql.jdbc.Driver");
        Connection connection = DriverManager.getConnection(url, username, password);
        PreparedStatement st = connection.prepareStatement("DELETE FROM Table WHERE name = ?");
        st.setString(1,name);
        st.executeUpdate(); 
    } catch(Exception e) {
        System.out.println(e);
    }
}

Upvotes: 22

Sudharsun
Sudharsun

Reputation: 761

Every open connection must be closed, or it won't get implemented and no errors will be displayed. First learned lesson.

public static void DeleteRow(String name) {
    try {  
        Class.forName("com.mysql.jdbc.Driver");
        Connection connection = DriverManager.getConnection(url, username, password);

        PreparedStatement st = connection.prepareStatement("DELETE FROM Table WHERE name = " + name + ";");
        st.executeUpdate(); 
        connection.close();
    } catch(Exception e) {
        System.out.println(e);
    }
}

Hope this helps

Upvotes: 0

Manash Ranjan Dakua
Manash Ranjan Dakua

Reputation: 311

          Class.forName("oracle.jdbc.driver.OracleDriver");
          Connection con = DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:XE", "MANASH_APPN","MANASH");
          PreparedStatement ps = con.prepareStatement("delete from EMP21 where empid = ?");
           ps.setInt(1,90);
           ps.executeUpdate();
          con.commit();
          System.out.println("Records Delete Successfully....");
         con.close();

Upvotes: 1

Asif alam
Asif alam

Reputation: 1

this will work String del="DELETE FROM table WHERE name =('" + name + "')";

:)

Upvotes: -1

wrecklez
wrecklez

Reputation: 347

try this bro. use Statement

Statement stmt = connection.createStatement();
String SQL = "DELETE FROM Table WHERE name = '"+name+"'";
stmt.executeUpdate(SQL);

Upvotes: 0

jeremyjjbrown
jeremyjjbrown

Reputation: 8009

You should never create a SQL statement in Java with String concatenation, it will be vulnerable to sql injection. Please do it this way.

String selectSQL = "DELETE FROM Table WHERE name = ?";
connection.prepareStatement(selectSQL);
preparedStatement.setString(1, name);

Upvotes: 2

Related Questions