CODEWITHSUNDEEP
iosiphoneobjective-cuibarbuttonitem
user3266395
user3266395

Reputation: 85

Setting UIBarButtonItem not changing title, changing only style

I have a UIBarButtonItem in the top right which says 'Edit'. When clicked, this code is called - I know so because the button is emboldened. However, the button's title does not change. Here is my code:

 // set to not editing and change buttons
        [self setEditing:YES animated:YES];
        UIBarButtonItem *doneButton = (UIBarButtonItem *)sender;
        [doneButton setTitle:@"Done"];
        [doneButton setStyle:UIBarButtonItemStyleDone];
        self.navigationItem.rightBarButtonItem = doneButton;

Edit 2:

The following code is doing what I want, however the first time I click the edit button, nothing happens.

-(void)editButton:(id)sender {
    self.navigationItem.rightBarButtonItem = [[UIBarButtonItem alloc] initWithTitle:@"Edit" style: UIBarButtonItemStylePlain target:self action:@selector(edit:)];

}

-(void) edit:(UIBarButtonItem *) barBtnItem
{
    // if not editing
    if (![self isEditing])
    {
        [self setEditing:YES];
        barBtnItem.tag = 1;
        [self.navigationItem.rightBarButtonItem setTitle:@"Done"];
    }
    else
    {
        [self setEditing:NO];
        barBtnItem.tag = 0;
        [self.navigationItem.rightBarButtonItem setTitle:@"Edit"];
    }
}

Upvotes: 1

Views: 9688

Answers (6)

doesnt_matter
doesnt_matter

Reputation: 121

Change type from System:Edit to Custom

Upvotes: 0

user4156224
user4156224

Reputation: 19

The simplest solution: Just change the BarButtonItem's identifier to custom.

Upvotes: 1

bhavya kothari
bhavya kothari

Reputation: 7474

You can do it via code as well as follows

UIBarButtonItem *rightBarButton = [[UIBarButtonItem alloc]initWithTitle:@"Done" style:UIBarButtonItemStylePlain target:self action:@selector(doneClicked:)];
self.navigationItem.rightBarButtonItem = rightBarButton;

Upvotes: 1

Macro206
Macro206

Reputation: 2163

What about this:

self.navigationItem.rightBarButtonItem = self.editButtonItem;

I think it does pretty much what you want it to do.

It changes to "Done" when tapped, and then back to "Edit" when tapped again. Furthermore it sets the view controllers editing property accordingly.

Upvotes: 4

Mani
Mani

Reputation: 17585

Just do this 

UIBarButtonItem *barButton = [[UIBarButtonItem alloc] initWithTitle:@"Edit" style: UIBarButtonItemStyleBordered target:self action:@selector(edit:)];
barButton.tag = 0;
barButton.possibleTitles = [NSSet setWithObjects:@"Edit", @"Done", nil];

Just change state according to click. simple thing.

-(void) edit:(UIBarButtonItem *) barBtnItem
{
     if (barBtnItem.tag == 0)
    {
       barBtnItem.tag = 1;
       [self.navigationItem.rightBarButtonItem setTitle:@"Done"];
    }
    else
    {
        barBtnItem.tag = 0;
        [self.navigationItem.rightBarButtonItem setTitle:@"Edit"];
    } 
}

Upvotes: 2

Tushar Koul
Tushar Koul

Reputation: 2980

From "title" property on the UIBarButtonItem reference

You should set this property before adding the item to a bar. The default value is nil.

Check this qn also

Upvotes: -1

Related Questions