DarthOpto
DarthOpto

Reputation: 1652

Why am I not getting the correct response?

I am a complete Python noob Now that the foreshadowing is done, I am trying to parse some information out of a SOAP response. The body of the reponse is below:

   <soap:Body>
  <ProcessMessageResponse xmlns="http://www.starstandards.org/webservices/2005/10/transport">
     <payload>
        <content id="Content0">
           <CustomerLookupResponse xmlns="">
              <Customer>
                 <CompanyNumber>ZQ1</CompanyNumber>
                 <CustomerNumber>1051012</CustomerNumber>
                 <TypeCode>I</TypeCode>
                 <LastName>NAME</LastName>
                 <FirstName>BASIC</FirstName>
                 <MiddleName/>
                 <Salutation/>
                 <Gender/>
                 <Language/>
                 <Address1/>
                 <Address2/>
                 <Address3/>
                 <City/>
                 <County/>
                 <StateCode/>
                 <ZipCode>0</ZipCode>
                 <PhoneNumber>0</PhoneNumber>
                 <BusinessPhone>0</BusinessPhone>
                 <BusinessExt>0</BusinessExt>
                 <FaxNumber>0</FaxNumber>
                 <BirthDate>0</BirthDate>
                 <DriversLicense/>
                 <Contact/>
                 <PreferredContact/>
                 <MailCode/>
                 <TaxExmptNumber/>
                 <AssignedSalesperson/>
                 <CustomerType/>
                 <PreferredPhone/>
                 <CellPhone>0</CellPhone>
                 <PagePhone>0</PagePhone>
                 <OtherPhone>0</OtherPhone>
                 <OtherPhoneDesc/>
                 <Email1/>
                 <Email2/>
                 <OptionalField/>
                 <AllowContactByPostal/>
                 <AllowContactByPhone/>
                 <AllowContactByEmail/>
                 <BusinessPhoneExtension/>
                 <InternationalBusinessPhone/>
                 <InternationalCellPhone/>
                 <ExternalCrossReferenceKey>0</ExternalCrossReferenceKey>
                 <InternationalFaxNumber/>
                 <InternationalOtherPhone/>
                 <InternationalHomePhone/>
                 <CustomerPreferredName/>
                 <InternationalPagerPhone/>
                 <PreferredLanguage/>
                 <LastChangeDate>20130401</LastChangeDate>
                 <Vehicles/>
                 <CCID/>
                 <CCCD>0</CCCD>
              </Customer>
           </CustomerLookupResponse>
        </content>
     </payload>
  </ProcessMessageResponse>
</soap:Body>

and I have the following code snippet to show what I have done to parse out the response I want:

customer_number = ''
customer_first_name = ''
customer_last_name = ''

def send_customer_lookup(data):
    soap_action = 'http://www.starstandards.org/webservices/2005/10/transport/operations/ProcessMessage'
source_port = random.randint(6000, 20000)
    webservice = httplib.HTTPSConnection('otqa.arkona.com', source_address=('', source_port))
    webservice.putrequest('POST', '/OpenTrack/Webservice.asmx?wsdl')
    webservice.putheader('User-Agent', 'OpenTrack-Heartbeat')
    webservice.putheader('Content-Type', 'application/soap+xml')
    webservice.putheader('Content-Length', '%d' % len(data))
    webservice.putheader('SOAPAction', soap_action)
    webservice.endheaders()
    webservice.send(data)
    response = webservice.getresponse()
    response_xml = str(response.read())

    doc = ET.fromstring(response_xml)
    for customer in doc.findall('.//{http://www.starstandards.org/webservices/2005/10/transport}Payload'):
        global customer_number
        global customer_first_name
        global customer_last_name
        customer_number = customer.findtext('{http://www.starstandards.org/webservices/2005/10/transport}CustomerNumber')
        customer_first_name = customer.findtext('{http://www.starstandards.org/webservices/2005/10/transport}FirstName')
        customer_last_name = customer.findtext('{http://www.starstandards.org/webservices/2005/10/transport}LastName')

   webservice.close()
   return customer_number, customer_first_name, customer_last_name, response_xml

I am not certain why I am getting an output of ' ', ' ', ' ', <xml response>...

Upvotes: 0

Views: 232

Answers (2)

Bob Belderbos
Bob Belderbos

Reputation: 87

you could use xml.dom.minidom :

from xml.dom import minidom

def parse_customer_data(response_xml):
    results = []
    dom = minidom.parseString(response_xml)
    customers=dom.getElementsByTagName('Customer')
    for c in customers:                                                                                                                      
        results.append({
            "cnum"  : c.getElementsByTagName('CustomerNumber')[0].firstChild.data,
            "lname" : c.getElementsByTagName('LastName')[0].firstChild.data,
            "fname" : c.getElementsByTagName('FirstName')[0].firstChild.data
       })
    return results

if __name__ == "__main__":
    response_xml = open("soap.xml").read()
    results = parse_customer_data(response_xml)
    print(results)

note that for the input file, soap.xml: 1. I added xml version / soap:Envelope elements around the XML you provided, otherwise it would not parse 2. I added another Customer element to test my code

output:

$ python soap.py 
[{'lname': u'NAME1', 'cnum': u'1051012', 'fname': u'BASIC1'}, {'lname': u'NAME2', 'cnum': u'1051013', 'fname': u'BASIC2'}]

Upvotes: 0

Hugh Bothwell
Hugh Bothwell

Reputation: 56624

It looks like you are overspecifying the field names, therefore they don't match anything, therefore your for customer in ... never runs. Try this:

import httplib
import xml.etree.ElementTree as ET

def send_customer_lookup(data):
    soap_action = 'http://www.starstandards.org/webservices/2005/10/transport/operations/ProcessMessage'
    source_port = random.randint(6000, 20000)
    with httplib.HTTPSConnection('otqa.arkona.com', source_address=('', source_port)) as webservice:
        webservice.putrequest('POST', '/OpenTrack/Webservice.asmx?wsdl')
        webservice.putheader('User-Agent', 'OpenTrack-Heartbeat')
        webservice.putheader('Content-Type', 'application/soap+xml')
        webservice.putheader('Content-Length', '%d' % len(data))
        webservice.putheader('SOAPAction', soap_action)
        webservice.endheaders()
        webservice.send(data)
        response_xml = str(webservice.getresponse().read())

    doc = ET.fromstring(response_xml)
    results = []
    for customer in doc.findall('.//CustomerLookupResponse/'):
        customer_number     = customer.findtext('CustomerNumber')
        customer_first_name = customer.findtext('FirstName')
        customer_last_name  = customer.findtext('LastName')
        results.append((customer_number, customer_first_name, customer_last_name))

   return results

Also, global variable names are generally evil; I presume that you added them because you were getting 'variable not defined' errors? That should have been a clue that the for-loop was not actually getting run.

Upvotes: 1

Related Questions