CODEWITHSUNDEEP
javascriptjquery
David 天宇 Wong
David 天宇 Wong

Reputation: 4187

jquery updating global variable

I have this code where I want to play the next song everytime I click on forward. Except he doesn't recognize ii, and throw me an error TypeError: playlist[ii] is undefined

I've tried window.ii, same error.

$(document).ready(function(){
ii = 0


var playlist = [
    {
        'name' : "Ida Maria - Oh My God",
        'src' : "01 Oh My God.m4a",
        'codec' : 'mp4'
    },
    {
        'name' : "Miley Cyrus - Wrecking Ball",
        'src' : "06 Wrecking Ball.mp3",
        'codec' : 'mpeg'
    }
]


  $('.forward').click(function(){
    ii++
    audio.unload()
    audio.urls = mp3_folder + playlist[ii].src
    audio.load()
    audio.play()
  })

Upvotes: 0

Views: 52

Answers (3)

Amir Rahnama
Amir Rahnama

Reputation: 6214

I'd say will tell you that you should not add stuff like that in your global scope. In your case, you do not need to poulate the global scope at all. Keep the scoping minimum.You also had a lot of lexical issues like missing semicolon at the end of lines and closing brackets but try the following:

$(document).ready(function(){
var ii = 0;


var playlist = [
    {
        'name' : "Ida Maria - Oh My God",
        'src' : "01 Oh My God.m4a",
        'codec' : 'mp4'
    },
    {
        'name' : "Miley Cyrus - Wrecking Ball",
        'src' : "06 Wrecking Ball.mp3",
        'codec' : 'mpeg'
    }
];


  $('.forward').click(function(){
    ii++;
    audio.unload();
    audio.urls = mp3_folder + playlist[ii].src;
    audio.load();
    audio.play();
  });

});

Upvotes: 2

DSlagle
DSlagle

Reputation: 1583

You need to move your playlist variable outside of your onload event method.

var playlist = [
    {
        'name' : "Ida Maria - Oh My God",
        'src' : "01 Oh My God.m4a",
        'codec' : 'mp4'
    },
    {
        'name' : "Miley Cyrus - Wrecking Ball",
        'src' : "06 Wrecking Ball.mp3",
        'codec' : 'mpeg'
    }
];

var ii = 0;

$(document).ready(function(){
    $('.forward').click(function(){
        ii++;
        audio.unload();
        audio.urls = mp3_folder + playlist[ii].src;
        audio.load();
        audio.play();
    });
});

You will probably want to move the ii variable outside as well or you will have the same issue.

Upvotes: 0

Omri Aharon
Omri Aharon

Reputation: 17064

Try declaring the playlist like this:

window.playlist

So you'll have

window.playlist = [
    {
        'name' : "Ida Maria - Oh My God",
        'src' : "01 Oh My God.m4a",
        'codec' : 'mp4'
    },
    {
        'name' : "Miley Cyrus - Wrecking Ball",
        'src' : "06 Wrecking Ball.mp3",
        'codec' : 'mpeg'
    }
]

Upvotes: 1

Related Questions