CODEWITHSUNDEEP
phparrays
Andy Holmes
Andy Holmes

Reputation: 8047

How to use array from one function, inside another function

I'm new to the world of OOP and PDO and just need a bit of a hand when returning data in one function and wanting to use that inside another function.

Below is my function to get all gecko data from my database, at the moment i have it printing out the array so i know it's working.

function getGecko:

public function getGecko($geckoName){
    $dbh = $this->dbh;
    try {
        if (!$geckoName) {
            throw new Exception("No gecko name set!");
        }
        $stmt = $dbh->query("SELECT * FROM geckos WHERE gecko_name = '$geckoName'");
        $stmt->setFetchMode(PDO::FETCH_ASSOC);  
        $row_count = $stmt->rowCount();  
        $row = $stmt->fetch();

        if($row_count > 0){
            print_r($row);
            return true;
        } else {
            echo 'No information found for '.$geckoName.'!';
            return false;
        }
    }
    catch (Exception $e) {
        echo $e->getMessage();
    }
}

which outputs as - Array ( [gecko_id] => 1 [gecko_name] => Zilly [gecko_aquisition_date] => 0000-00-00 [gecko_type] => Normal [gecko_gender] => Male [gecko_traits] => [gecko_bio] => Hench bastard [gecko_health_check] => All good! [gecko_bred] => 0 [gecko_hatchling] => 0 [gecko_clutch] => [gecko_photo] => ) - no problem.

But i want to use that data inside a function called getMorph to utilise [gecko_type] => Normal. I have tried things like:

public function getMorph($geckoName){
    $this->getGecko($geckoName);
    echo $row['gecko_type'];
}

But it returns nothing at all. I am quite used to php in the procedural sense, i'm just trying to better myself and my code and wanted to get stuck into OOP. I do apologise if this is considered a 'noob' question but as i say, i am trying to learn.

Thank you for your time :)

Upvotes: 0

Views: 988

Answers (2)

Amal Murali
Amal Murali

Reputation: 76666

The problem with your first function is that you're returning a boolean value. No actual data is returned. Also, in the getMorph() function, you're trying to use the $row variable. This won't work as the $row variable only exists inside the local scope of the function getGecko(). This would actually cause PHP to print an error message. Had you enabled error reporting, you'd have found this out.

To fix the issue, you can modify your first function to return the array:

    if($row_count > 0){
        // print_r($row);
        return $row;
    } else {
        echo 'No information found for '.$geckoName.'!';
        return false;
    }

Then, in your second function, you can access the array like so:

public function getMorph($geckoName){

    // $morph now contains the entire array 
    // returned by the other function
    $row = $this->getGecko($geckoName);

    // output the array contents
    echo '<pre>' . print_r($row, TRUE), '</pre>';

    // return the specific gecko_type value
    return $row['gecko_type'];
}

I suggest you read up on variable scope. It's going to be very useful. Also, completely unrelated the issue above, you're directly inserting the user input in your SQL query. Don't do that! Use parameterized queries instead - that way, you'll be able to avoid SQL injection attacks.

The following questions has more details on the subject:

Upvotes: 1

user2073253
user2073253

Reputation:

Your function getGecko returns only a Boolean and $row is only a local variable in that method. So you can either change the return value to return the actual data or you can create a private variable in your PHP Class.

For changing the return type, you could in getGecko change that return to something like this:

if($row_count > 0){
    // ...
    return $row;
}

And then in your getMorph function do something like:

public function getMorph($geckoName){
    $row = $this->getGecko($geckoName);
    echo $row['gecko_type'];
}

Upvotes: 1

Related Questions