Struts2 validation, repopulate all the fields when validation fails

Question

I have 2 pages, the first where the user insert the data, and the second where the user confirm the data (or can go back to the edit page). The problem is that when validation fails, all the values in fields are erased. Somebody suggested to use prepare(), but It's a lot of work to copy all the fields, does it exist a faster way to repopulate all the fields?

the first page (formDatiUtente.jsp):

<%@ page language="java" contentType="text/html;"
     import="java.util.*,it.alm.bean.*,it.alm.delegate.*;"%>
<%@ taglib prefix="s" uri="/struts-tags"%>





Registrazione account













 




    <%
        String pathContest=request.getContextPath();
        //Collection clRichAna = (ArrayList)request.getAttribute("clRichAna");
        //String totRich=(clRichAna!=null?""+clRichAna.size():"0");

        //Collection comuni = (ArrayList)request.getAttribute("comuni");
        List  comuni = CreazioneUtenzaDelegate.getInstance().getComuni();
    %>





                
                    
                        
                            
                        
                    
                    
                        
                            
                        
                    
                
                
                    
                        
                    
                    
                        
                    
                
                
                    
                        
                    
                    
                        
                        
                        

                            
                                
                            
                    
                
                
                    
                         
                    
                        
                        
                    
                




                
                     
                         Comune: 
                    
                    
                        
                   
                

                    
                        Ente:
                    
                    
                        
                    
                
                
                                            
                        Tipo Ufficio:
                    
                    
                         
                    
                
                
                    
                        Ufficio:

That after the submit go here (visualizzaDatiRichiesta.jsp), I use hidden value to copy the data when the user go back to the previous page (it's not the best way I suppose, but I inherit part of the code from a co-worker):

<%@ page language="java" contentType="text/html;"
    import="java.util.*,it.alm.bean.*,it.alm.delegate.*;"%>
<%@ taglib prefix="s" uri="/struts-tags"%>





Riepilogo dati richiesta


<% String pathContest=request.getContextPath();
%>

 







    

    
    
    
    
    
    

    
      
        
        
    
       
      
      


    
    
    

    
    



     
         
            Riepilogo dati richiesta
         
      
     
        
        
                     .............................................................................................................................
        
     
     
         
          
                 ..................................................................................................................................
        
     
     
        
          
                              .....................................................................................................................
        
      
     
     
          
                     ..............................................................................................................................
        
     
     
       
        
                                                            .......................................................................................
       
      
       
         
           
                                             .........................................................................................................
         
      
       
         
            @
                      .................................................................................................................................
         
      
       
         
            
                                                                      ................................................................................
         
       
       
         
           Applicativo richiesto
                                       .............................................................................................................

So, let's pass to the action, this is relative to the first jsp (this extend another action):

 public class InserimentoDatiAction extends RegisterAction implements Preparable {

    private static final long serialVersionUID = 1L;

    public InserimentoDatiAction()
    {
    }

    public String execute() 
    {
        refreshDWR();

        return "success";

    }

    public void refreshDWR()
    {
        String idComune = null;
        try
        {
            idComune = getAnagraficaVDR().getUfficio().getComune().getCodComune();
        }
        catch (NullPointerException e)
        {
            //qualche campo � incompleto, le combobox non vengono caricate
        }

        if ( idComune != null)
        {
            DwrAjaxServiceImplEnti dwrEnte = new DwrAjaxServiceImplEnti();
            this.setListaEnte( dwrEnte.get_Ente( idComune ) );
            String idEnte = getAnagraficaVDR().getUfficio().getTipoufficio().getEnte().getIdEnte();
            if ( idEnte != null)
            {
                DwrAjaxServiceImplTipoUfficio dwrTipoUff = new DwrAjaxServiceImplTipoUfficio();
                this.setListaTipoUffici( dwrTipoUff.get_TipoUfficio(idComune, idEnte) );
                String idTipoUff = getAnagraficaVDR().getUfficio().getTipoufficio().getIdTipoUfficio();
                if ( idTipoUff != null)
                {
                    DwrAjaxServiceImplUfficio dwrUff = new DwrAjaxServiceImplUfficio();
                    this.setListaUffici( dwrUff.get_Ufficio(idComune, idEnte, idTipoUff));
                }
            }
        }
    }

    @Override
    public void prepare() throws Exception 
    {
        this.setDominiMail( CreazioneUtenzaDelegate.getInstance().getEmails() );
        this.setListaComuni( CreazioneUtenzaDelegate.getInstance().getComuni() );
        this.setListaApplicazioni( CreazioneUtenzaDelegate.getInstance().getApplicazioni() );
        this.setListaQualifiche( CreazioneUtenzaDelegate.getInstance().getQualifiche() );
        this.getSession().put("listaApplicazioni", this.getListaApplicazioni());
        this.getSession().put("listaQualifiche", this.getListaQualifiche());
    }

    public boolean isGestioneAmministratore()
    {
        return false;
    }

}

This is relative to the second jsp (the confirmation page):

public class InviaRichiestaAction extends ActionSupport implements Preparable, SessionAware 
{

    private static final long serialVersionUID = 1L;

    private String cognome;
    private String nome;
    private Date dataNascita;

    private List listaQualifiche;
    private String qualificaSelezionata;
    private String qualificaSelezionataDescrizione;

    private String comuneSelezionato;
    private String ente;
    private String tipoufficio;
    private String ufficio;


    private String telefono;
    private String email;
    private String confermaEmail;
    private String ilTuodominio_Email;
    private String ilTuodominio_EmailConferma;

    private String ip;

    private String applicazioniSelezionate;
    private String applicazioniSelezionateDesc;
    private String identi;

    private static List listaTipoUfficio = new ArrayList();
    private static List listaUfficio = new ArrayList();

    //questo blocco di variabili anche se non è usato sta qui 
    //per non generare errori di validazione:
    private List listaComuni = new ArrayList();
    private List listaEnte = new ArrayList();
    private List dominiMail = new ArrayList();
    private List listaTipoUffici = new ArrayList();
    private List listaUffici = new ArrayList();
    private List listaApplicazioni;


    private Map session;

    public String execute() 
    {       
        qualificaSelezionataDescrizione = BeanCopyUtil.getDescriptionFromBeanList(listaQualifiche, qualificaSelezionata, "getIdQualifica", "getDescrizione");
        setApplicazioniSelezionateDesc(BeanCopyUtil.getDescriptionFromBeanList(listaApplicazioni, applicazioniSelezionate, "getIdApplicazione", "getDescrizione"));
        return "success";
    }

    @Override
    public void prepare() throws Exception 
    {
        listaQualifiche = (List) this.getSession().get("listaQualifiche");       
        listaApplicazioni = (List) session.get("listaApplicazioni");
    }

    public String getDescrizioneTipoUfficioEUfficio()
    {
        String descrizioneTipoUfficioEUfficio = "";
        if (listaTipoUfficio!=null && !listaTipoUfficio.isEmpty())
        {
            Iterator it1 = listaTipoUfficio.iterator();
            while (it1.hasNext())
            {
                ComboBean elem = it1.next();
                if (elem.getIdValue().equals(tipoufficio))
                {
                    descrizioneTipoUfficioEUfficio += elem.getValue();
                    break;
                }
            }
            if (!listaUfficio.isEmpty())
            {
                it1 = listaUfficio.iterator();
                while (it1.hasNext())
                {
                    ComboBean elem = it1.next();
                    if (!elem.getValue().trim().isEmpty() && elem.getIdValue().equals(ufficio))
                    {
                        descrizioneTipoUfficioEUfficio += " - " + elem.getValue();
                        break;
                    }
                }
            }
        }
        return descrizioneTipoUfficioEUfficio;
    }

[...a lot of boring getter and setter...]

}

The superclass of InserimentoDatiAction:

public class RegisterAction extends ActionSupport implements SessionAware {
    private static final long serialVersionUID = 1L;

    private Anagrafica anagraficaVDR = new Anagrafica();

    private String comuneSelezionatoVDR;
    private String ilTuodominio_EmailVDR;
    private String applicazioniSelezionateVDR;

    private List dominiMail;
    private List listaComuni;
    private List listaApplicazioni;
    private List listaQualifiche;

    private List listaEnte = new ArrayList();
    private String enteSelezionatoVDR;
    private List listaTipoUffici = new ArrayList();
    private String tipoUfficioSelezionatoVDR;
    private List listaUffici = new ArrayList();
    private String ufficioSelezionatoVDR;

    private String qualificaSelezionataDescrizioneVDR;
    private String descrizioneTipoUfficioEUfficioVDR;
    private String applicazioniSelezionateDescVDR;

    private Map session;
[...other less important stuff...]
}

part of struts.xml, formDatiUtente is the first jsp, visualizzaDatiRichiesta is the second (confirmation jsp):


    /jsp/creazioneUtenza/formDatiUtente.jsp


    /jsp/creazioneUtenza/visualizzaDatiRichiesta.jsp
    /jsp/creazioneUtenza/formDatiUtente.jsp
    /jsp/pannelloDiGestione/menu.jsp

Andrea Ligios · Accepted Answer

Action1 extends the one containing the AnagraficaVDR used to set the value;

Action2 extends simply ActionSupport, it doesn't know anything about an object called AnagraficaVDR.

When you post the form to Action2, and it fails validation, INPUT result returns the first JSP, without the first Action backing its data.

You have to rethink the mechanism a bit:

if you want to repopulate the first JSP with the ORIGINAL values from AnagraficaVDR, you have to provide AnagraficaVDR to Action2 too (maybe by declaring two actions in struts.xml pointing to two methods of the same action containing AnagraficaVDR...)

But this is generally avoided, because if I've changed 10 fields from their original values, and one of them is failing the validation, I want it to return my 10 ALTERED values, to be able to change only the failing one. With the solution provided above, it will reset all to AnagraficaVDR values, not the just entered values.

Then you should find another way, simpler and effective, like

populating your Action1 properties from AnagraficaVDR in the first Action execute (or prepare) method,
remove all value="%{AnagraficaVDR.something" from your tags in JSP1.*

_{*NOTE: this is based on your previous question code, where the tag had name="properties" and value="%{AnagraficaVDR.properties}"}

This way the first action will populate the values from AnagraficaVDR only the first time, then keeping the entered values in case of SUCCESS or INPUT.

Struts2 validation, repopulate all the fields when validation fails

Answers (1)

Related Questions