CODEWITHSUNDEEP
javalistarraylist
Kendy E. Benold
Kendy E. Benold

Reputation: 43

Java previous elements in ArrayList/List being overwritten when changing next element

I am a bit new to Java. In the forLoop below, I am looping over the elements of the arraylist and I am trying to change the position object. When the forLoop is finished, the position for all the elements is equivalent to the value in the last element. I debugged through this, but can figure out why this is occuring.

edit: the function below is where I am initializing and populating the options. It also contains the logic to set the position for each option.

protected void InitializeOptions() {
    options = new ArrayList<Button>();
    options.add(new Button("button.png", "Quick Fire"));
    options.add(new Button("button.png", "20 Questions"));
    options.add(new Button("button.png", "Decisions! Decisions!"));
    options.add(new Button("button.png", "OMG"));

    for(int i = 0; i < OPTIONCOUNT; ++i) {
        options.get(i).SetPosition(i*35, i*35);
    }
}

My objects element is declared as a generic list of Button objects like below. I am not sure if that makes a difference.

List<Button> options = new ArrayList<Button>();

edit: I have one class that is button that has two important objects: PositionedTexture background and PositionedText text. Each of those objects has a Vector2 for a position. The code for each class is below

public class PositionedTexture {
    public Texture Texture;
    public Vector2 Position;

    public PositionedTexture(String texturePath) {
        Texture = new Texture(Gdx.files.internal(texturePath));
        Position = Vector2.Zero;
    }

    public PositionedTexture(String texturePath, Vector2 position) {
        Texture = new Texture(Gdx.files.internal(texturePath));
        Position = position;
    }
}

public class PositionedTexture {
    public Texture Texture;
    public Vector2 Position;

    public PositionedTexture(String texturePath) {
        Texture = new Texture(Gdx.files.internal(texturePath));
        Position = Vector2.Zero;
    }

    public PositionedTexture(String texturePath, Vector2 position) {
        Texture = new Texture(Gdx.files.internal(texturePath));
        Position = position;
    }
}

public class Button {
    protected PositionedTexture background;
    protected PositionedText text;
    protected Vector2 center;
    protected Vector2 scale;
    protected float rotation;
    protected Rectangle rect;
    protected ShapeRenderer shapeRenderer;

    public Button(String spritePath, String btnText) {
        background = new PositionedTexture(spritePath);
        text = new PositionedText(btnText);
        rect = new Rectangle(6, 41, 498, 171);
        center = new Vector2((rect.width - rect.x)/2, (rect.height - rect.y)/2);
        scale = new Vector2(0.5f,0.5f);
        rotation = 0.0f;
        shapeRenderer = new ShapeRenderer();
    }

    public Button(String spritePath, String btnText, Vector2 pos) {
        background = new PositionedTexture(spritePath, pos);
        text = new PositionedText(btnText, pos);
        rect = new Rectangle(6, 41, 498, 171);
        center = new Vector2((rect.width - rect.x)/2, (rect.height - rect.y)/2);
        scale = new Vector2(0.5f,0.5f);
        rotation = 0.0f;
        shapeRenderer = new ShapeRenderer();
    }

    public void SetPosition(Vector2 pos) {
        background.Position = pos;
        text.Position = pos;
    }

    public void SetPosition(float x, float y) {
        background.Position.x = x;
        background.Position.y = y;
        text.Position.x = x;
        text.Position.y = y;
    }

    public void Draw(SpriteBatch batch, BitmapFont font) {
        // draw background
        batch.draw(background.Texture, background.Position.x, 
                   background.Position.y, center.x, center.y,
                   background.Texture.getWidth(), background.Texture.getHeight(),
                   scale.x, scale.y, rotation, (int)rect.x, (int)rect.y,
                   (int)rect.width, (int)rect.height, false, false);

        // draw text
        font.setColor(0, 0, 0, 1);
        font.draw(batch, text.Text, text.Position.x, text.Position.y);

        // draw collision rect
        shapeRenderer.begin(ShapeType.Line);
        shapeRenderer.setColor(1, 0, 0, 1);
        shapeRenderer.rect(background.Position.x, background.Position.y,
                           background.Texture.getWidth() * scale.x,
                           background.Texture.getHeight() * scale.y);
        shapeRenderer.end();
    }
}

Upvotes: 4

Views: 962

Answers (2)

Gurubaran
Gurubaran

Reputation: 788

Ahhhh I see the problem... It is in the class PositionedTexture. You are not creating a new Position for each Button. So basically all the Buttons position point to the Vector2.Zero.

Creating a new Position element is the way to go... 

public class PositionedTexture {
public Texture Texture;
public Vector2 Position;

public PositionedTexture(String texturePath) {
    Texture = new Texture(Gdx.files.internal(texturePath));
    Position = Vector2.Zero;
}

public PositionedTexture(String texturePath, Vector2 position) {
    Texture = new Texture(Gdx.files.internal(texturePath));
    Position = position;
}

Upvotes: 5

Chris Gerken
Chris Gerken

Reputation: 16392

Make sure that you didn't put the same instance of the object in all positions of the array list - in other words add the same element over and over again. That's what would probably cause the behavior you're seeing.

Upvotes: 3

Related Questions