CODEWITHSUNDEEP
c++
template boy
template boy

Reputation: 10480

Why is this stream buffer not working?

I have a very simple stream buffer setup that forwards the bytes from a stream to the buffer. When I print I get a weird output, namely "HellHelllo," instead of "Hello". Maybe my eyes are tired, but I can't find the problem here. Why am I getting is output?

#include <iostream>
#include <vector>
#include <string>
#include <algorithm>
#include <sstream>

class io_buffer : public std::streambuf
{
public:
    io_buffer(std::istream& is, int buf_size = 4)
        : size(buf_size) , is_(is) , buffer(std::max(buf_size, 1))
    {
        char* end = &buffer.front() + buffer.size();
        setg(end, end, end);
    }

    int_type underflow()
    {
        if (gptr() < egptr())
            return traits_type::to_int_type(*gptr());

        if (is_)
        {
            std::copy_n(std::istreambuf_iterator<char>(is_),
                        size, std::back_inserter(buffer));

            char* beg = &buffer.front();
            setg(beg, beg, beg + buffer.size());
            return traits_type::to_int_type(*gptr());
        }
        return traits_type::eof();
    }
private:
    int size;
    std::istream& is_;
    std::vector<char> buffer;
};

int main()
{
    std::istringstream oss("Hello, World");
    io_buffer buf(oss);

    std::istream is(&buf);
    std::string str;

    is >> str;
    std::cout << str << std::endl; // "HellHelllo,"
}

Upvotes: 1

Views: 544

Answers (2)

user2249683
user2249683

Reputation:

You initialize the buffer with (maybe 4) zeros 

buffer(std::max(buf_size, 1))

and append the content to the buffer without clearing the buffer.

You may change it to:

int_type underflow()
{
    if (gptr() < egptr())
        return traits_type::to_int_type(*gptr());

    if (is_)
    {
        char* beg = buffer.data();
        char* end = std::copy_n(
            std::istreambuf_iterator<char>(is_),
            size, beg);
        setg(beg, beg, end);
        return traits_type::to_int_type(*gptr());
    }
    return traits_type::eof();
}

You still have a bug here: std::copy_n might ask for too many characters.

Make it:

int_type underflow()
{
    if (gptr() < egptr())
        return traits_type::to_int_type(*gptr());

    if (is_)
    {
        char* beg = buffer.data();
        char* end = beg;
        char* limit = beg + buffer.size();
        std::istreambuf_iterator<char> in(is_);
        std::istreambuf_iterator<char> eos;
        for( ; end < limit && in != eos; ++end, ++in)
            *end = *in;
        setg(beg, beg, end);
        if(beg < end)
            return traits_type::to_int_type(*gptr());
    }
    return traits_type::eof();
}

And eliminate the member size.

Upvotes: 2

Pratik Deoghare
Pratik Deoghare

Reputation: 37212

I think this is because underflow gets called twice.

This could be a bug.

Upvotes: 1

Related Questions