CODEWITHSUNDEEP
ruby-on-railsrake
rajat banerjee
rajat banerjee

Reputation: 1294

Call Application Controller functions from Rake task

I want to call a function in my ApplicationController from a rake task. I've added the => :environment tag, but it just doesn't want to work.

Here is my stripped down code-

lib\taks\autoscrape.rake:
 desc "This task will scrape all the movies without info"
  task(:autoscrape => :environment) do
    require 'application'  #probably extraneous
    require File.dirname(__FILE__) + '/../../config/environment' #probably extraneous
    unless ApplicationController.is_admin?
      logger.error = "Sorry, you're not allowed to do that"
      return
    end


app\controller\application_controller.rb:
class ApplicationController < ActionController::Base
  helper :all # include all helpers, all the time

  def is_admin?
        session[:is_admin] && session[:is_admin] > 0
  end
end

result:
rake scrape:autoscrape --trace
** Invoke scrape:autoscrape (first_time)
** Invoke environment (first_time)
** Execute environment
** Execute scrape:autoscrape
rake aborted!
undefined method `is_admin?' for ApplicationController:Class
E:/Dropbox/My Dropbox/Ruby/moviecat/lib/tasks/autoscrape.rake:11

My other controllers call this code all the time, no problems. How can my Rake task call this code? This is greatly simplified, it is part of a bigger problem, i would like to reuse more code.

Thanks!!

Upvotes: 6

Views: 8185

Answers (4)

vladzaets
vladzaets

Reputation: 53

In your rake task you have:

unless ApplicationController.is_admin?

You should add .new to controller name:

unless ApplicationController.new.is_admin?

Upvotes: -1

William Richerd
William Richerd

Reputation: 69

Create a instance for controller and call the method.method inside the controller should be public method.

Example: 

objEmail = EmailController.new

objEmail.message

Upvotes: 6

juanmah
juanmah

Reputation: 1189

Maybe the reason of rajat does not make sense, but the question is valid.

I need to do some maintenance and I need to execute a function inside a class. It is a workaround to get things fixed one time (like migration), and it is not imperative to do it by the proper way.

It can be done calling a url instead of calling a rake (with suitable setting of route and parameters).

It can be done by defining functions out of class (making it public).

Or it can be done as William Richerd has proposed, which, by the way, it works.

Upvotes: 0

theIV
theIV

Reputation: 25774

First, the error you are getting is because you are calling ApplicationController.is_admin? which isn't defined because your method is defined on instances of ApplicationController, not on the ApplicationController class.

Second, the concept of session (at least to me) doesn't really make too much sense in a rake task. There are no real sessions other than your user's session at the command line which is not what you would be getting.

To be honest, I don't know the best way for going about calling a Controller action/method from anywhere outside of classes that inherit from ApplicationController or ActionController::Base, or why you would want to. Those actions/methods are specifically designed to be used during a request, not some action that you call whenever. If you really need something and don't want to redefine it, put it in a model/library and include it.

Upvotes: 6

Related Questions