CODEWITHSUNDEEP
javascriptajaxgetelementbyid
eben
eben

Reputation: 229

document.getElementById(somevar) not working

i have the code below but getElementById(setID) not working for me, i know it catches the id because alert(setID) working.

any idea?

function getdata(file, aID){
req = xmlHttpRequestHandler.createXmlHttpRequest();
req.onreadystatechange = Response;
req.open("GET", file, true);
req.send(null);
setID = aID;
}

function Response() { 
    var ready, status;
    try {
        ready = req.readyState;
        status = req.status;
    }
    catch(e) {}
    if (ready == 4 && status == 200) {
          document.getElementById("data").innerHTML = req.responseText;
    }

   document.getElementById(setID).className = "someclass";
}


<div class="msg" id="someid">
<a href="javascript:getdata('data.php', 'someid')">somelink</a>
</div>

Upvotes: 1

Views: 1198

Answers (3)

Sarfraz
Sarfraz

Reputation: 382841

Are you making your setID variable global? If not then try this:

var setID = null; // we set this here because it is referenced in functions

function getdata(file, aID){
req = xmlHttpRequestHandler.createXmlHttpRequest();
req.onreadystatechange = Response;
req.open("GET", file, true);
req.send(null);
setID = aID;
}

function Response() { 
    var ready, status;
    try {
        ready = req.readyState;
        status = req.status;
    }
    catch(e) {}
    if (ready == 4 && status == 200) {
          document.getElementById("data").innerHTML = req.responseText;
    }

   document.getElementById(setID).className = "someclass";
}

Upvotes: 1

rahul
rahul

Reputation: 187110

Either use setID as a global variable or pass it to the callback function.

function getdata(file, aID)
{
    req = xmlHttpRequestHandler.createXmlHttpRequest();
    setID = aID;
    req.onreadystatechange = function() {Response(setID);};
    req.open("GET", file, true);
    req.send(null);
}

function Response(setID)

Upvotes: 4

Pekka
Pekka

Reputation: 449713

If

document.getElementById("data")

doesn't work, this has one of the following reasons in 99% of all cases:

  • The element does not exist or exist anymore

  • There are more than one element with the id data

This happens often when the AJAX call introduces HTML code that also contains an element with the same ID.

Upvotes: 1

Related Questions