CODEWITHSUNDEEP
javascriptnode.jspromiseq
pedalpete
pedalpete

Reputation: 21536

q.all being returned before promise is completed

I'm trying to use q.all to manage the process of multiple npm install module_name methods.

Strangely, it appears as though the promise is being returned before the promise is completed. 

installNodeModules: function(module_list){
            function installModule(module_name){
                var defer = q.defer();
                console.log(module_name);
                exec_child_process('npm install '+module_name, function(err,stdout,stderr){
                    if(err) defer.reject(err);
                    defer.resolve();
                    return defer.promise;
                });
            }

            var promise_array = [];
            for (var i =0; i<module_list.length;i++){
                promise_array.push(installModule(module_list[i]));   
                console.log('promises array created');
            }

             q.all(promise_array).done(function(){
                    console.log('promises returned');   
                });
        },

I've tried using both the done & then methods after the all, but same result, the promise is returned before npm install has completed.

Upvotes: 2

Views: 330

Answers (1)

Dan D.
Dan D.

Reputation: 74655

installModule should be written like this:

        function installModule(module_name){
            var defer = q.defer();
            console.log(module_name);
            exec_child_process('npm install '+module_name, function(err, stdout, stderr){
                if(err) { 
                   defer.reject(err);
                } else {
                   defer.resolve();
                }
            });
           return defer.promise;
        }

It is installModule which should return the promise, not the callback.

Upvotes: 4

Related Questions