CODEWITHSUNDEEP
javascriptpromise
Woodgnome
Woodgnome

Reputation: 2391

How to catch promise runtime Javascript errors?

I'm currently implementing a PDF viewer based on PDF.js and as part of that I learned about promise objects.

I also learned that runtime errors are not automatically shown in the debugging console:

PDFJS.getDocument(...).then(
  function(pdfDocument){
    alert(UndefinedVariable); // Not shown in console!
  },
  function(error){
    console.log("Error occurred", error);
  }
);

I haven't been able to find a pretty way to show runtime errors in the promise functions, other than adding .done() as described in http://www.asyncdev.net/2013/07/promises-errors-and-express-js/ (which doesn't work for PDF.js) or adding .catch(function(error){ console.error(error); }).

I know that I can break on exceptions from runtime errors in the debugger, but I also get breaks on other exceptions (in jQuery) by doing so, which means I have to step thorugh 5 jQuery exceptions on every page load, before I can even check if my own code contains runtime errors.

Is there any way to force the promise functions to log runtime errors like normal (without writing extra code for every function call)?

Upvotes: 6

Views: 4090

Answers (2)

Bergi
Bergi

Reputation: 665584

The problem you're experiencing is that an exception in the then callback does reject the promise returned by .then(), instead of calling the error handler that you passed in. That will only trigger for errors in the promise on which you called .then(). So you can chain your handlers:

PDFJS.getDocument(...).then(function(pdfDocument){
    alert(UndefinedVariable); // Now shown in console!
}).then(null, function(error){
    console.log("Error occurred", error);
});

Here, then(null, …) could also be abbreviated by catch(…).

If there is no done method that throws on errors, you could implement it yourself like this by throwing in a setTimeout.

Is there any way to force the promise functions to log runtime errors like normal (without writing extra code for every function call)?

No. That's just not how they were designed.

Upvotes: 7

Tibos
Tibos

Reputation: 27853

In the Promise implementation, there is a try ... catch which takes an error from the callbacks and turns it into an error returned by the Promise.

One thing you can do is change that try...catch to log the errors before invoking the failure of the promise.

https://github.com/mozilla/pdf.js/blob/master/src/shared/util.js#L936

    } catch (ex) {
      console.error(ex); // <--- add this line
      nextStatus = STATUS_REJECTED;
      nextValue = ex;
    }

If native ECMAScript 6 promises are used instead, this trick probably won't work.

Upvotes: 1

Related Questions