CODEWITHSUNDEEP
c#argumentexception
Gaurav K.
Gaurav K.

Reputation: 67

Unhandled System.ArgumentException.. Additional Information: Parameter is not valid

I have this code in c# that pulls images from database and shows them in PictureBox. Whenever I run code first, I get this error saying "An unhandled exception of type 'System.ArgumentException' occurred in System.Drawing.dll Additional information: Parameter is not valid." But if I terminate and rerun the program, it works just fine giving intended results. Here is part of the code that is giving me trouble:

 private void buttonGetImage_Click(object sender, EventArgs e)
    {
        string baseUrl = "http://someurl";
        HttpWebRequest request = null;
        foreach (var fileName in fileNames)
        {
            string url = string.Format(baseUrl, fileName);
            MessageBoxButtons buttons = MessageBoxButtons.OKCancel;
            DialogResult result;
            result = MessageBox.Show(url, fileName, buttons);

            if (result == System.Windows.Forms.DialogResult.Cancel)
            {
                this.Close();
            }

            request = (HttpWebRequest)WebRequest.Create(url);
            request.Method = "GET";
            request.ContentType = "application/x-www-form-urlencoded";
            request.CookieContainer = container;

            response = (HttpWebResponse)request.GetResponse();
            Stream stream = response.GetResponseStream();

            byte[] buffer = new byte[10000000];
            int read, total = 0;

            while ((read = stream.Read(buffer, total, 1000)) != 0)
            {
                total += read;
            }
            MemoryStream ms = new MemoryStream(buffer, 0, total);
            ms.Seek(0, SeekOrigin.Current);
            Bitmap bmp = (Bitmap)Bitmap.FromStream(ms);
            pictureBoxTabTwo.Image = bmp;
            this.pictureBoxTabTwo.SizeMode = PictureBoxSizeMode.Zoom;
            pictureBoxTabTwo.Image.Save("FormTwo.jpg", System.Drawing.Imaging.ImageFormat.Jpeg);
        }
    }

Can someone help me to figure out what can be done? Error is showing me line --> Bitmap bmp = (Bitmap)Bitmap.FromStream(ms);

Upvotes: 0

Views: 14760

Answers (4)

mesutpiskin
mesutpiskin

Reputation: 1927

You can try it

pictureBox1.Image = new Bitmap(sourceBitmap);

Upvotes: 0

Gaurav K.
Gaurav K.

Reputation: 67

Instead of using Bitmap class I used Image class in my program. What I was doing here was taking a stream and putting it into a byte array. And again converting content of that array back to stream. Instead, I used

Image img = Image.FromStream(stream)

In this case You don't even have to use MemoryStream. It is working perfectly find for me now.

Upvotes: 1

JamieSee
JamieSee

Reputation: 13010

You need to do proper object disposal. Otherwise, the underlying connection doesn't close until the garbage collector catches up with the object and that can cause problems. Also, in .NET 4.0 and higher you can use the CopyTo method on Streams.

        request = (HttpWebRequest)WebRequest.Create(url);
        request.Method = "GET";
        request.ContentType = "application/x-www-form-urlencoded";
        request.CookieContainer = container;

        using (response = (HttpWebResponse)request.GetResponse())
        using (Stream stream = response.GetResponseStream())
        {
            // All of this code is unnecessary if using .NET 4.0 or higher.
            /*
            byte[] buffer = new byte[10000000];
            int read, total = 0;

            while ((read = stream.Read(buffer, total, 1000)) != 0)
            {
                total += read;
            }
            MemoryStream ms = new MemoryStream(buffer, 0, total);
            ms.Seek(0, SeekOrigin.Current);
            */
            // Instead use the following
            MemoryStream ms = new MemoryStream();
            stream.CopyTo(ms);

            Bitmap bmp = (Bitmap)Bitmap.FromStream(ms);
            pictureBoxTabTwo.Image = bmp;
            this.pictureBoxTabTwo.SizeMode = PictureBoxSizeMode.Zoom;
            pictureBoxTabTwo.Image.Save("FormTwo.jpg", System.Drawing.Imaging.ImageFormat.Jpeg);
        }

Upvotes: 0

Crono
Crono

Reputation: 10478

Hard to tell from your code what the problem could be, but likely the query you are making on the server returns an unexpected response in some circumstances. You'd be best to get a snapshot of the returned stream when things goes wrong. It will allow you to diagnose the problem and take appropriate measures.

Upvotes: 0

Related Questions