CODEWITHSUNDEEP
node.jsexpress
user435943
user435943

Reputation: 974

Waiting for multiple callbacks in Node.js

I have a Node.js application where multiple funcions might be called, depending on several factors, but only one last function is called after the last callback.

This is a simplified version of what I got:

if(foo === bar){
    function1(arg1, function(val1){
        doWhatever(val1, function(){
            res.end("Finished");
        });
    });
}else if(foo === baz){
    function2(arg2, function(val2){ 
        doWhatever(val2, function(){
            res.end("Finished");
        });
    });
}else{
    function3(arg3, function(val3){
        doWhatever(val3, function(){
            res.end("Finished");
        });
    });
}

And this is what im doing:

var finished = false;

if(foo === bar){
    function1(arg1, function(val1){
        result = val1;
        finished = true;
    });
}else if(foo === baz){
    function2(arg2, function(val2){ 
        result = val2;
        finished = true;
    });
}else{
    function3(arg3, function(val3){
        result = val3;
        finished = true;
    });
}

var id = setInterval(function(){
    if(finished === true){
        clearInterval(id);
        doWhatever(result, function(){
            res.end("Finished");
        });
    }
}, 100);

I guess this can be simplified by using promises, however im not sure how should I implement them.

Upvotes: 7

Views: 6874

Answers (3)

jgillich
jgillich

Reputation: 76189

You could also do it using when and promises, which IMHO is the easiest to read.

var promises = [];

if(x) {
    var deferred1 = when.defer();
    doSomethingAsync({ callback: deferred1.resolve });
    promises.push(deferred1.promise);
} else if(y) {
    var deferred2 = when.defer();
    doSomethingAsync({ callback: deferred2.resolve });
    promises.push(deferred2.promise);
} else if(z) {
    var deferred3 = when.defer();
    doSomethingAsync({ callback: deferred3.resolve });
    promises.push(deferred3.promise);
}

when.all(promises).then(function () {
    console.log('Finished Promises');
});

Upvotes: 8

Lucio M. Tato
Lucio M. Tato

Reputation: 5805

Here's using wait.for

https://github.com/luciotato/waitfor

//in a fiber
var result;
if(foo === bar){
    result = wait.for(function1,arg1);
}else if(foo === baz){
    result = wait.for(function2,arg2);
}else{
    result = wait.for(function3,arg3);
};

doWhatever(result, function(){
        res.end("Finished");
});

You need to be in a fiber (or generator) to use wait.for, but, if you have a lot of callback hell, wait.for is a good approach.

Upvotes: 3

aembke
aembke

Reputation: 2649

Here's one way with async series.

https://github.com/caolan/async#series

async.series([
    function(callback){
        if(foo === bar){
            function1(arg1, function(val1){
                callback(null, val1);
            });
        }else if(foo === baz){
            function2(arg2, function(val2){ 
                callback(null, val2);
            });
        }else{
            function3(arg3, function(val3){ 
                callback(null, val3);
            });
        }
    }  
], function(error, valArray){
       doWhatever(valArray[0], function(){
           res.end("Finished");
       });
});

Upvotes: 3

Related Questions