CODEWITHSUNDEEP
phpipv6maxmind
scytale
scytale

Reputation: 1399

inet_pton() warning on IPv6 addresses - error in my code, or server config?

I'm developing an open source plugin for use 3rd party sites. It includes this snippet to obtain a visitors country code:

$visitorIP = $_SERVER['REMOTE_ADDR'];

if( filter_var($visitorIP, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4) ) {
    $geoIPdb = 'GeoIP.dat';
} elseif ( filter_var($visitorIP, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6) ) {
    $geoIPdb = 'GeoIPv6.dat';
} else return 'something';

include_once($this->maxmindDirectory . 'geoip.inc');
$gi = geoip_open($this->maxmindDirectory . $geoIPdb, GEOIP_STANDARD);

if($geoIPdb == 'GeoIP.dat') {
    $ISOcode = geoip_country_code_by_addr($gi, $visitorIP); }
else {
    $ISOcode = geoip_country_code_by_addr_v6($gi, $visitorIP);
}

My server and ISP both use IPv4 and the code works for IPv4 addresses; but I can't test real visitor IPv6 addresses.

However, if I test by hard coding $visitorIP as an IPv6 address I get an "inet_pton() [function.inet-pton]: Unrecognized address" warning.

  1. Is this an error in my code, or down to my server/PHP configuration? (When I checked AF_INET6 was undefined.)

  2. If its not my error, will this code work correctly on servers where $_SERVER['REMOTE_ADDR'] contains an IPv6 address, or do I still need to add additional checks?

Thanks for any advice.

Upvotes: 1

Views: 3366

Answers (1)

user2629998
user2629998

Reputation:

Your server's PHP is compiled without IPv6 support (using the --disable-ipv6) so your code fails, however it should work fine on a server on which PHP supports IPv6.

Here's how to check if IPv6 is supported on your PHP installation, taken from here :

if (defined('AF_INET6')) {
  echo "PHP was compiled without --disable-ipv6 option";
} else {
  echo "PHP was compiled with --disable-ipv6 option";
}

By the way, here's how I would rewrite your code, it looks better to me but I'm far from being a PHP expert so use it at your own risk.

function getISOcode($visitorIP) {
    if(filter_var($visitorIP, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {
        $geoIPdb = "GeoIP.dat";

        include_once($this->maxmindDirectory."geoip.inc");
        $gi = geoip_open($this->maxmindDirectory.$geoIPdb, GEOIP_STANDARD);

        return geoip_country_code_by_addr($gi, $visitorIP);
    } elseif (filter_var($visitorIP, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
        $geoIPdb = "GeoIPv6.dat";

        include_once($this->maxmindDirectory."geoip.inc");
        $gi = geoip_open($this->maxmindDirectory.$geoIPdb, GEOIP_STANDARD);

        return geoip_country_code_by_addr($gi, $visitorIP);
    } else {
        return false; // or throw an exception about the address being invalid
    }
}

Upvotes: 4

Related Questions