CODEWITHSUNDEEP
c++fstream
user3487267
user3487267

Reputation: 1

Trying to open file using fstream but it is not working

I am trying to run this but the file is constantly failing to load. What I am trying to do is load a dictionary into an Array with each level of an array accounting for one word.

#include <iostream>
#include <string>
#include <fstream>>
#include <time.h>
#include <stdlib.h>

using namespace std;

int Rand;

void SetDictionary(){
srand(time(NULL));
Rand = rand() % 235674;
fstream file("Hangman.txt");
if(file.is_open()){
    string Array[235675];

    for(int X = 0; X < 235673; X++){
        file >> Array[X];
    }
    cout << Array[Rand];
   }else{
    cout << "Unable To Open File\n";
}
}

int main(){
SetDictionary();
}

Upvotes: 0

Views: 124

Answers (2)

Sergey Prokhorov
Sergey Prokhorov

Reputation: 135

At first, I see you do not reuse Array after cout << Array[Rand] is done. You do not need array at all in this case. Read the file line by line into temp variable and cout this variable if condition X==Rand, then break. At second, the implementation could be improved. Assumed you are trying to cout random word from file. It would be 1000-times faster to generate Rand as 0..file-size, then offset to this Rand. Now you are "inside" desired word and the task is to read back and forward for the work begin and end respectively. This algorithm will show a bit different probability distribution. At third. If you plan to reuse file data, it would be much faster to read whole file into memory, and then do split by words, storing words offsets as arrays of integers. At last. With really huge dictionaries (or if the program run on limited memory) it is possible to store words offsets only, and re-read dictionary contents on-the-fly.

Upvotes: 0

Neil Kirk
Neil Kirk

Reputation: 21803

vector<string> words;
{
    ifstream file("Hangman.txt");
    string word;
    while (file >> word)
    {
        words.push_back(word);
    }
}

string randword = words[rand() % words.size()];

Upvotes: 4

Related Questions