CODEWITHSUNDEEP
javareturn
user3531560
user3531560

Reputation: 261

"Missing return statement" within if / for / while

I have a question regarding return statements used within if() while() or for() statements.

As you can see in the following method, it is expecting that I return a String value. The problem is that if I were to use a return statement within my if statement block, the compiler would return the error missing return statement.

public String myMethod()
{
    if(condition)
    {
        return x;
    }
}

Of course I could change the method header to void and use System.out.println instead of return. But is this the right way to do it? Am I missing something?

Upvotes: 22

Views: 182755

Answers (7)

loknath
loknath

Reputation: 1372

Anyhow, myMethod() should return a String value. What if your condition is false? - is myMethod returning anything? The answer is no, so you need to define return null or some string value for the false condition:

public String myMethod() {
    boolean c = true;
    if (conditions) {
        return "d";
    }
    return null; // Or some other string value
}

Upvotes: 1

CodeCamper
CodeCamper

Reputation: 6980

That is illegal syntax. It is not an optional thing for you to return a variable. You must return a variable of the type you specify in your method.

public String myMethod()
{
    if(condition)
    {
        return x;
    }
}

You are effectively saying: I promise any class can use this method (public) and I promise it will always return a String (String).

Then you are saying IF my condition is true I will return x. Well, that is too bad. There isn't any IF in your promise. You promised that myMethod will always return a String.

Even if your condition is always true, the compiler has to assume that there is a possibility of it being false. Therefore you always need to put a return at the end of your non-void method outside of any conditions just in case all of your conditions fail.

public String myMethod()
{
    if(condition)
    {
        return x;
    }
    return ""; // Or whatever the default behavior will be if all of your conditions fail to return.
}

Upvotes: 5

bNd
bNd

Reputation: 7630

Try with, as if the if condition returns false, so it will return empty, otherwise nothing to return.

public String myMethod()
{
    if(condition)
    {
        return x;
    }
    return ""
}

Because the compiler doesn't know if any of those if blocks will ever be reached, so it's giving you an error.

Upvotes: 3

Deepu--Java
Deepu--Java

Reputation: 3820

This will return the string only if the condition is true.

public String myMethod()
{
    if(condition)
    {
        return x;
    }
    else
        return "";
}

Upvotes: 1

Guillermo Merino
Guillermo Merino

Reputation: 3257

That's because the function needs to return a value. Imagine what happens if you execute myMethod() and it doesn't go into if(condition) what would your function return? The compiler needs to know what to return in every possible execution of your function.

Checking Java documentation:

Definition: If a method declaration has a return type then there must be a return statement at the end of the method. If the return statement is not there the missing return statement error is thrown.

This error is also thrown if the method does not have a return type and has not been declared using void (i.e., it was mistakenly omitted).

You can do this to solve your problem:

public String myMethod()
{
    String result = null;
    if(condition)
    {
        result = x;
    }
    return result;
}

Upvotes: 6

Bhushan Kawadkar
Bhushan Kawadkar

Reputation: 28513

If you put a return statement in the if, while or for statement then it may or may not return a value. If it will not go inside these statements then also that method should return some value (that could be null). To ensure that, compiler will force you to write this return statement which is after if, while or for.

But if you write an if / else block and each one of them is having a return in it then the compiler knows that either the if or else will get executed and the method will return a value. So this time the compiler will not force you.

if(condition)
{
    return;
}
else
{
    return;
}

Upvotes: 17

d3vnico
d3vnico

Reputation: 93

You have to add a return statement if the condition is false.

public String myMethod() {
    if(condition) {
        return x;
    }

//  if condition is false you HAVE TO return a string
//  you could return a string, a empty string or null
    return otherCondition;  
}

FYI:

Oracle docs for return statement

Upvotes: 1

Related Questions