CODEWITHSUNDEEP
asp.net-mvcrazorhtml-helper
Eugene Goldberg
Eugene Goldberg

Reputation: 15534

How to properly encode links to external URL in MVC Razor

This view suppose to show a list of hyperlinks, each pointing to an external URL. The goal is for the user to click one of these links and have their browser open a new tab with the selected URL. Currently I have the following markup:

@Html.ActionLink("SomeSite", "http://subdomain.mydomain.com/SomeSite")

This markup produces:

http://localhost:58980/AccessInstance/http%3a/subdomain.mydomain.com/SomeSite

instead of :

http://subdomain.mydomain.com/SomeSite

What can I change in my markup to make this work as I expect?

Upvotes: 23

Views: 63095

Answers (6)

carloswm85
carloswm85

Reputation: 2382

Using .NET Core 6

This seems to be the most correct answer:

 <a [email protected] target="_blank">Link</a>

This will generate the following result:

enter image description here

As you can see at the bottom left corner of the window before clicking the link, the URL address was rendered as it is (NOTE: The cursor was recorded out of place for some reason, that's a ShareX problem, ignore it).

Than link will be directly saved as a nvarchar(750) type (probably any character like type will do the work). No changes to the original link were made before saving it or on reading:

enter image description here

Upvotes: 1

Shaiju T
Shaiju T

Reputation: 6609

Two ways :

1. update the database column with full link:

eg SQL:

update ProductTable set ProductLink='http://www.example.com/Product/Mobiles' where ID=123

In asp mvc view

<a href="@model.ProductLink">View</a>

2. Hardcode the http part and list from model

<a href="http://@model.ProductLink">View</a>

Hope helps someone.

Upvotes: 17

saktiprasad swain
saktiprasad swain

Reputation: 340

Here to display link that are clickable in index page

     <td>         
        @Html.ActionLink(item.FileName, "../Uploads/Catalogue/"+item.FileName)
    </td>

Upvotes: -1

Tom Stickel
Tom Stickel

Reputation: 20401

While a ViewBag is overused and not the best choice most of the time this is something that I had done when inheriting someone else's mvc app to do a quick fix for a URL that I needed to redirect to with a specific dynamically changing querystring parameter

  <a target="_parent" href="http://localhost:56332/services/@ViewBag.factory">View Service</a>

Upvotes: 0

Zinov
Zinov

Reputation: 4119

You need to take into account your RouteConfiguration.

routes.MapRoute( name: "Default", url: "{controller}/{action}"

because you are specifying the action link as the entire link that you want to redirect. I would recommend that you use the @rossipedia answer because you can make tricky things like putting a span inside the link

Upvotes: -1

rossipedia
rossipedia

Reputation: 59367

You don't need to use @Html.ActionLink for that. Just use a plain A tag: 

<a href="http://subdomain.mydomain.com/SomeSite">SomeSite</a>

Html.ActionLink is specifically for generating links to actions defined in MVC controllers, in the same app. Since you're linking to an absolute URL, you don't need any of the functionality that Html.ActionLink provides.

Upvotes: 41

Related Questions