CODEWITHSUNDEEP
iosobjective-creactive-cocoa
melbic
melbic

Reputation: 12217

ReactiveCocoa- Error in map method

I'm writing an method which gets a Signal from a Webservice and then converts it from a NSDictionary to an object. But what if there's an error happening in this conversion?

Will I return an RACSignal error:error] then?

[signal map:^id(NSDictionary *dictionary) {
    NSError *error;
    SAMWebServiceResponse *samResponse = [MTLJSONAdapter modelOfClass: SAMWebServiceResponse.class
                                                   fromJSONDictionary: dictionary
                                                                error: &error];
    if (error) {
        //TODO: Don't know if this is the way to go.
        return [RACSignal error:error];
    } else {
        return samResponse;
    }
  }
]

Upvotes: 2

Views: 391

Answers (1)

Ian Henry
Ian Henry

Reputation: 22403

ReactiveCocoa has a construct exactly for this situation called tryMap:. Check it out:

[signal tryMap:^id(NSDictionary *dictionary, NSError **errorPtr) {
    return [MTLJSONAdapter modelOfClass:SAMWebServiceResponse.class
                     fromJSONDictionary:dictionary
                                  error:errorPtr];
}]

This assumes that modelOfClass:fromJSONDictionary:error: will return nil when an error occurs -- which is pretty standard -- but it's worth checking the docs on that just in case. The code as you've written it now will just return that error signal, which is a completely legitimate thing to do (signals of signals are the best part of RAC), but not what you want here.

Upvotes: 3

Related Questions