CODEWITHSUNDEEP
asp.net-mvcmodel-view-controllercontrollerrepository
Rookian
Rookian

Reputation: 20539

BestPractices: Is it acceptable to use more than one repository in a MVC-Controller?

I have a many-to-many assocition between an Employee and a Team. Foreach entity I have a repository.

Now I use ASP.NET MVC and I created a EmployeeController. I also created a View to edit an Employee. For this view I need a DropDownList with all Teams. The problem is that my EmployeeController only has got EmployeeRepository. So how can I get all Teams? My solution now is to use two repositories.

But is this a good solution?

Could I instead create TeamController and write a method returning all Teams (how would I do that)?

Upvotes: 12

Views: 1380

Answers (4)

Mark Seemann
Mark Seemann

Reputation: 233125

It's quite OK, but once you feel that the Controller becomes too cluttered, you can refactor its dependencies to an Aggregate Service.

Upvotes: 9

Mikeon
Mikeon

Reputation: 10749

Wanna go smart? Do not use repositories inside controllers whatsoever. Instead use Domain Services. It doesn't sound so bad when you think one controller integrates the work of many services doesn't it?

Upvotes: 3

blu
blu

Reputation: 13175

Typically you would create a repository for the aggregate root. The repository would have methods returning the entities populated for the controller.

If the entities are totally unrelated in your domain model you may want to create a service wrapping the two separate repositories to get the data you need.

Upvotes: 1

Jim G.
Jim G.

Reputation: 15365

Yes, it's perfectly acceptable for a controller to have references to two repositories.

In fact, my controllers work with multiple repositories more often than not.

Upvotes: 8

Related Questions