CODEWITHSUNDEEP
javascripthyperlinkundefinedhref
Bogdan Bogdanov
Bogdan Bogdanov

Reputation: 992

JavaScript - Undefined link when I change href of a link

I use code from HERE (Stackoverflow.com)

I do it for my stuff like this 

var i = 0;
var links = ["http://www.example.com/page","http://www.example.com/anotherpage"];
var renew = setInterval(function(){
    document.getElementById("changelink").href = links[i];        
    if(links.length==i){
        i=0;
    }else{
        i++;
    }
},5000);
<a id='changelink' href='http://google.bg/'>test</a>

but when the link change it writes me undefined, I try with the same code with iframe and also gives me undefined whats going on ?

Upvotes: 0

Views: 1120

Answers (1)

adeneo
adeneo

Reputation: 318182

Your count is off by one

var i = 0;
var links = ["http://www.example.com/page", "http://www.example.com/anotherpage"];
var renew = setInterval(function () {
    document.getElementById("changelink").href = links[i];
    if (links.length - 1 == i) {
        i = 0;
    } else {
        i++;
    }
}, 5000);

When links.length == i you're actually trying to get an array index that doesn't exists, so you'll have to subtract one and do links.length - 1 == i

Upvotes: 3

Related Questions