std::out of range of vector<string>

Question

I know this question is too old but i can't find any solution.

This is my code:

#include "iostream"
#include "string"
#include "vector"
#include "conio.h"
#include "fstream"
using namespace std;
using std::vector;

#define Ifile "Input.txt"
#define Ofile "Output.txt"
#define token1 "."
#define token2 "!"
#define token3 "?"

struct Wordcount
{
        string wor;
        int NOtime;
};

void SplitParagraph(vector<string> &source,string token);
void Import(vector<string> &source);
int Wordcounting(string s);
vector<Wordcount> Listword(vector<string> source);
vector<string> SplitSentence(string s);
vector<string> Themostwords(vector<Wordcount> List);
vector<vector<string>> WordSort(vector<string> List);
void Export(vector<string>& source,vector<Wordcount>& List,vector<string>& TheMost,vector<vector<string>> WordSort);

void main()
{
        vector<string> source;

        Import(source);
        Export(source,Listword(source),Themostwords(Listword(source)),WordSort(source));
        cout<<"Completed, please see the result in "<<Ofile;
        _getch();
}

void SplitParagraph(vector<string> &source,string token)
{
        for(int i = 0;i<source.size();i++)
        {
                char *temp = NULL;
                temp = (char *)source.at(i).c_str();
                string tempsentence=strtok(temp,token.c_str());
                while(!tempsentence.empty())
                {
                        source.insert(source.begin()+i,tempsentence);
                        i++;
                }
        }
}

void Import(vector<string> &source)
{
        fstream file;
        char* fin = "Input.txt";
        file.open(fin,ios::in||ios::out);
        while(!file.eof())
        {
                getline(file,source.at(0));
        }
        SplitParagraph(source,token1);
        SplitParagraph(source,token2);
        SplitParagraph(source,token3);
        file.close();
}

int Wordcounting(string s)
{
        int count = 0;
        for(int i = 0;i<s.length();i++)
        {
                if(s[i] == ' ')
                        count++;
        }
        return count;
}

vector<Wordcount> Listword(vector<string> source)
{
        vector<Wordcount> List;
        vector<string> newsource = source;
        SplitParagraph(newsource," ");
        for(int i = 0;i<newsource.size();i++)
                for(int j = 0;j<List.size();j++)
                        if(newsource.at(i) == List.at(j).wor)
                                List.at(j).NOtime++;
                        else
                        {
                                List.at(List.size()).wor = newsource.at(i);
                                List.at(List.size()).NOtime = 0;
                        }
        return List;
}

vector<string> SplitSentence(string s)
{
        vector<string> result;
        char * S = new char[s.length() + 1];
        std::strcpy(S,s.c_str());
        string temp = strtok(S," ");

        while(temp.empty())
        {
                result.at(result.size())=temp;
                temp = strtok(S," ");
        }
        return result;
}

vector<string> Themostwords(vector<Wordcount> List)
{
        vector<string> result;
        int max = 0;
        for(int i = 0;i<List.size();i++)
                if(max<List.at(i).NOtime)
                        max = List.at(i).NOtime;
        for(int i = 0;i<List.size();i++)
                if(max == List.at(i).NOtime)
                        result.at(result.size()) = List.at(i).wor;
        return result;
}

vector<vector<string>> WordSort(vector<string> List)
{
        vector<vector<string>> result;
        for(int i = 0;i<List.size();i++)
                result.at(i) = SplitSentence(List.at(i));
        for(int i = 0;i<List.size();i++)
                for(int j = 0;j<result.at(i).size();j++)
                        for(int k = result.at(i).size(); k>j; k--)
                        {
                                int leng = result.at(i).at(j).length()<result.at(i).at(k).length()?result.at(i).at(j).length():result.at(i).at(k).length();
                                for(int z = 0;z<leng;z++)
                                        if((int)result.at(i).at(j)[z]<(int)result.at(i).at(k)[z])
                                        {
                                                string temp;
                                                temp = result.at(i).at(j);
                                                result.at(i).at(j)=result.at(i).at(k);
                                                result.at(i).at(k)=temp;
                                        }
                        }
                        return result;
}

void Export(vector<string>& source,vector<Wordcount>& List,vector<string>& TheMost,vector<vector<string>> WordSort)
{
        fstream data;
        data.open(Ofile,ios::out);
        data<<source.size()<<endl;
        for(int i = 0;i<source.size();i++)
                data<<List.at(i).NOtime<<endl;
        for(int i = 0;i<TheMost.size();i++)
                data<<TheMost.at(i)<<" ";
        data<<" ";
        for(int i = 0;i<WordSort.size();i++)
        {
                for(int j = 0;j<WordSort.at(i).size();j++)
                        data<<WordSort.at(i).at(j)<<" ";
                data<<endl;
        }
        data.close();
}

I got problem in

void Import(vector<string> &source)
{
        fstream file;
        char* fin = "Input.txt";
        file.open(fin,ios::in||ios::out);
        while(!file.eof())
        {
                getline(file,source.at(0));
        }
        SplitParagraph(source,token1);
        SplitParagraph(source,token2);
        SplitParagraph(source,token3);
        file.close();
}

When i run to

getline(file,source.at(0));

Compiler said:Unhandled exception at at 0x758E1D4D in 02.exe: Microsoft C++ exception: std::out_of_range at memory location 0x003FF4D8.

Then i using std::string

void Import(vector<string> &source)
{
        fstream file;
        char* fin = "Input.txt";
        file.open(fin,ios::in||ios::out);
        std:string STRING;
        while(!file.eof())
        {
                getline(file,STRING);
        }
        SplitParagraph(source,token1);
        SplitParagraph(source,token2);
        SplitParagraph(source,token3);
        file.close();
}

but I don't know how to copy "STRING" to "source"

I try to search but not found.

How to fix out_of_range error or copy "STRING" to "source"

All i need is solve problem.

Thanks all!

Answer 1

void Import(vector<string> &source)
{
        fstream file;
        char* fin = "Input.txt";
        file.open(fin,ios::in||ios::out);
        std:string STRING;
        while(!file.eof())
        {
                getline(file,STRING);
                source.push_back(STRING);
        }
        SplitParagraph(source,token1);
        SplitParagraph(source,token2);
        SplitParagraph(source,token3);
        file.close();
}

Answer 2

You must be trying to access an empty vector. replace the code getline(file,source.at(0)); by

string temp;
getline(file,temp); //store the string in temporary variable
source.push_back(temp); // add the string in vector