CODEWITHSUNDEEP
asp.netasp.net-mvc
Yaplex
Yaplex

Reputation: 2284

Create link for asp.net mvc application

I have menu on my website, some links are internal and builds with Html.ActionLink method, and some are external and builds with tag.

But I don't like this code, I prefere to have one line instead of two lines. But I don't know how to do it, can anybody help me please?

<table width="100%" border="0" cellpadding="0" cellspacing="0">
<%
    foreach (AtomicCms.Core.DomainObjectsImp.MenuItem item in Model.MenuItems)
    {
        if (!item.IsExternalUrl)
        {
%>
<tr align="left">
    <td>
        <%=Html.ActionLink(Html.Encode(item.Title), "Content", "Home", new { id = item.Entry.Id, name = item.Entry.Alias }, new {title = Html.Encode(item.Title), @class="mainlevel"})%>
    </td>
</tr>
<%}
        else
        {
%>
<tr align="left">
    <td>
        <a href="<%=item.NavigateUrl %>" class="mainlevel">
            <%=Html.Encode(item.Title)%></a>
    </td>
</tr>
<%} %>
<%
    } %>

Upvotes: 2

Views: 1106

Answers (2)

tvanfosson
tvanfosson

Reputation: 532435

Why not build the link in your controller and incorporate it into the model? Then you only need the second line? That is, your MenuItem model is a collection of links and their associated text. Use the UrlHelper in the Controller to create the link in the controller.

Upvotes: 0

jrotello
jrotello

Reputation: 4601

I would extract this out to an html helper method. It would look something like:

public static string MenuItemLink(this HtmlHelper html, MenuItem item) {
    ...
}

Your view code would look somthing like: <%= Html.MenuItemLink(item) %>

Upvotes: 3

Related Questions