CODEWITHSUNDEEP
c#task
Keshavdas M
Keshavdas M

Reputation: 702

Task does not wait for ContinueWith to finish

I have console application and code as below,

My problem is before ContinueWith task finish, the console application ends, it does not waits the continueWith to finish, please advise.

Please let me know what I am missing or incorrect.

var task1 = Task<bool>.Factory.StartNew(() => DoProcess());

task1 .ContinueWith(
     t1 => updateSuccess(),
       TaskContinuationOptions.NotOnFaulted | TaskContinuationOptions.ExecuteSynchronously);

task1 .ContinueWith(
     t => updateFault(),
     TaskContinuationOptions.OnlyOnFaulted | TaskContinuationOptions.ExecuteSynchronously);

task1.Wait();

Upvotes: 4

Views: 11793

Answers (3)

NwP_290
NwP_290

Reputation: 9

I tried another solution that worked for me :

try {
    taskNotOnFaulted.Wait();
} catch {
    taskOnlyOnFaulted.Wait();
}

Upvotes: 0

TheOnlyMaX
TheOnlyMaX

Reputation: 29

Jorge's solution is not working when an exception is thrown :

var task = new Task(() =>
    {
        Console.WriteLine("My task...");
        throw new Exception();
    });

task.Start();

var taskNotOnFaulted = task.ContinueWith(t =>
{
    Thread.Sleep(1000);
    Console.WriteLine("NotOnFaulted");
}, TaskContinuationOptions.NotOnFaulted | TaskContinuationOptions.ExecuteSynchronously);
var taskOnlyOnFaulted = task.ContinueWith(t =>
{
    Thread.Sleep(1000);
    Console.Write("OnlyOnFaulted");
}, TaskContinuationOptions.OnlyOnFaulted | TaskContinuationOptions.ExecuteSynchronously);

Task.WaitAny(taskNotOnFaulted, taskOnlyOnFaulted);

Console.WriteLine("Finished");

The output is :

My task...
Finished
OnlyOnFaulted

This is because the taskNotOnFaulted get a Cancelled status when the exception is thrown, whereas it keeps a WaitingForActivation status when no exception is thrown.

So you have to replace :

Task.WaitAny(taskNotOnFaulted, taskOnlyOnFaulted);

by 

if (task.IsFaulted)
    taskOnlyOnFaulted.Wait();
else
    taskNotOnFaulted.Wait();

Upvotes: 2

Jorge C&#243;rdoba
Jorge C&#243;rdoba

Reputation: 52133

You have to wait on the task to complete from the main thread. Simplified it'll look like

var task1 = Task<bool>.Factory.StartNew(() => DoProcess());

successContinuation = task1 .ContinueWith(t1 => updateSuccess(),
                                          TaskContinuationOptions.NotOnFaulted | TaskContinuationOptions.ExecuteSynchronously)
failureContinuation = task1 .ContinueWith( t => updateFault(),
                                          TaskContinuationOptions.OnlyOnFaulted | TaskContinuationOptions.ExecuteSynchronously);

Task.WaitAny(successContinuation, failureContinuation);

I think you're not realizing that you're creating a task that will (actually just may) execute in a different thread. The moment you start your task you have two different threads of execution the main thread, which will continue to run, and your task. If you want your main thread (your console application) to wait for the task to finish, you have to manually specify it.

Upvotes: 8

Related Questions