CODEWITHSUNDEEP
phplaravel-4eloquent
Malchesador
Malchesador

Reputation: 795

Call to undefined method Illuminate\Database\Query\Builder::save()

I am trying to call Eloquent's save() method on an existing record but getting an error from Illuminate's Query Builder.

Following the documentation on Laravel's web site at http://laravel.com/docs/eloquent#insert-update-delete for updating a retrieved model, and also looking at the example here: Laravel Eloquent ORM save: update vs create, my code appears to follow the expected convention, but instead I get the error mentioned in the title of this post.

$this->employee                  = Employee::where('login', $login);
$this->employee->first_name         = 'John';
$this->employee->last_name          = 'Doe';
$this->employee->save();

The Employee class extends Eloquent, and if I create a new instance of the model and then set some attributes and then call the save() method it performs the insert statements just fine. What am I missing?

Upvotes: 19

Views: 42726

Answers (3)

Hakim Benmazouz
Hakim Benmazouz

Reputation: 331

Maybe more details for better understanding

With your Employee model :

if you make

Employee::find(1)

This will return a Eloquent model object (Instance of Employee Class)

if you make

Employee::where('field',op,value)

This will return a Builder object (Instance of Laravel Builder class)

if you make

Employee::where('field',op,value)->get()

This will return a Collection of your object (List of Employee instance)

if you make

Employee::where('field',op,value)->first()

This first() execute the get() function and then return the first element of the collection.

Laravel models extends Model class, and in this Model class is the save() function. so to be able to call it you have to have an instance of your model and not something else.

RM : be aware of the first() function, if there is 2 elements returned this result behave like there is only one result and its not true. in your case the login is declared as unique in the db so it should not be a problem, but be aware for another situations.

Upvotes: 1

Malchesador
Malchesador

Reputation: 795

Apparently the ->get() method will not work with Eloquent's ->save() method and you must use ->first() instead.

Correct: $this->employee = Employee::where('login', $login)->first();

Incorrect: $this->employee = Employee::where('login', $login)->get();

See http://laravel.io/forum/06-04-2014-symfony-component-debug-exception-fatalerrorexception-call-to-undefined-method-illuminatedatabaseeloquentcollectionsave for additional reference.

Upvotes: 38

EselDompteur
EselDompteur

Reputation: 139

you have to fetch your model after given an ->where

$this->employee = Employee::where('login', $login)->get();

or

$this->employee = Employee::where('login', $login)->first();

if you don't do that your Object $this->employee would't be one and you could not use ->save()

Upvotes: 10

Related Questions