CODEWITHSUNDEEP
ruby-on-railsruby-on-rails-4rails-activerecord
Justin
Justin

Reputation: 4940

Simple active record query

I have a feeling this question is easy, but maybe I am just overthinking it..

I have an Active Record query that looks like this:

@activities = PublicActivity::Activity.includes(:owner, :trackable).where(owner_id: current_user.followed_users, owner_type: "User", kind: "Activity")

This works great, but I'd like to add current_user as a possible :owner. So I've tried many options, including:

@activities = PublicActivity::Activity.includes(:owner, :trackable).where(owner_id: [[current_user.followed_users], [current_user]], owner_type: "User", kind: "Activity")
@activities = PublicActivity::Activity.includes(:owner, :trackable).where(owner_id: [current_user.followed_users, current_user], owner_type: "User", kind: "Activity")

However I'm getting errors like:

Cannot visit User::ActiveRecord_Associations_CollectionProxy

Can anyone spot the mistake I'm making...thanks

Upvotes: 1

Views: 217

Answers (2)

Brad Werth
Brad Werth

Reputation: 17647

current_user.followed_users is an ActiveRecord_Associations_CollectionProxy, but you only want the ids, like so - current_user.followed_users.collect(&:id)

Using your example, the full query would look something like this:

@activities = PublicActivity::Activity.includes(:owner, :trackable).where(owner_id: [[current_user.followed_users.collect(&:id)], [current_user.id]], owner_type: "User", kind: "Activity")

Upvotes: 2

Joe Kennedy
Joe Kennedy

Reputation: 9443

You can append the current_user to the array of followed_users. Try this:

allowed_users = current_user.followed_users << current_user
@activities = PublicActivity::Activity.includes(:owner, :trackable).where(owner_id: allowed_users, owner_type: "User", kind: "Activity")

Or you can just add current_user as a one element array to the their followed_users.

allowed_users = current_user.followed_users + [current_user]
@activities = PublicActivity::Activity.includes(:owner, :trackable).where(owner_id: allowed_users, owner_type: "User", kind: "Activity")

Upvotes: 2

Related Questions