Not able to call two different methods under same action class without using validation.excludeMethods

Question

Struts.xml:




    

        
            /Profile.jsp
            /LoginError.jsp
        

        
            /Success.jsp
            /login.jsp

I'm trying to map two Action in this XML to two different methods in Action class

LoginAction.java:

package login.action;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts2.interceptor.ServletRequestAware;
import org.apache.struts2.interceptor.ServletResponseAware;
import com.opensymphony.xwork2.ActionSupport;
import login.service.LoginDao;
import login.service.RegisterDao;

@SuppressWarnings("serial")
public class LoginAction extends ActionSupport implements ServletRequestAware,
        ServletResponseAware {

    private String username;
    private String password;
    private HttpServletRequest httpServletRequest;
    private String firstname;
    private String lastname;
    private String regpassword;
    private String conpassword;
    private String regemail;
    private String conemail;
    private String phone;
    
    public String register(){
        RegisterDao rdao = new RegisterDao();
        String registered = rdao.registerdao(firstname,lastname,regpassword,conpassword,regemail,conemail,phone);
        if(registered == "TRUE"){
            return SUCCESS;
        }
        
        return INPUT;
    }
    
    
    public String login() {
        System.out.println("user name::: "+username);
        httpServletRequest.getSession().setAttribute("key", username);
        httpServletRequest.getSession().setAttribute("key", password);
        LoginDao db = new LoginDao();
        Boolean validate = db.loginresult(username, password);
        if (validate == true) {
            return SUCCESS;

        } else {
            return INPUT;
        }
    }
    
    public HttpServletRequest getHttpServletRequest() {
        return httpServletRequest;
    }

    public void setHttpServletRequest(HttpServletRequest httpServletRequest) {
        this.httpServletRequest = httpServletRequest;
    }

    public String getFirstname() {
        return firstname;
    }

    public void setFirstname(String firstname) {
        this.firstname = firstname;
    }

    public String getLastname() {
        return lastname;
    }

    public void setLastname(String lastname) {
        this.lastname = lastname;
    }

    public String getRegpassword() {
        return regpassword;
    }

    public void setRegpassword(String regpassword) {
        this.regpassword = regpassword;
    }

    public String getConpassword() {
        return conpassword;
    }

    public void setConpassword(String conpassword) {
        this.conpassword = conpassword;
    }

    public String getRegemail() {
        return regemail;
    }

    public void setRegemail(String regemail) {
        this.regemail = regemail;
    }

    public String getConemail() {
        return conemail;
    }

    public void setConemail(String conemail) {
        this.conemail = conemail;
    }

    public String getPhone() {
        return phone;
    }

    public void setPhone(String phone) {
        this.phone = phone;
    }

    public void setServletRequest(HttpServletRequest request) {
        this.httpServletRequest = request;

    }


    public String getUsername() {
        return username;
    }

    public void setUsername(String username) {
        this.username = username;
    }

    public String getPassword() {
        return password;
    }

    public void setPassword(String password) {
        this.password = password;
    }

    @Override
    public void setServletResponse(HttpServletResponse arg0) {
        // TODO Auto-generated method stub

    }
    
    

}

Action Class with login and register methods:

login.jsp

<%@ page language="java" contentType="text/html; charset=ISO-8859-1"
    pageEncoding="ISO-8859-1"%>




Insert title here


    
        <%@ taglib uri="/struts-tags" prefix="s"%>

Login.jsp which is redirecting to the login method in Action class. Earlier it was working fine. Now this action gives trouble:

Registration.jsp

<%@ page language="java" contentType="text/html; charset=ISO-8859-1"
    pageEncoding="ISO-8859-1"%>




Insert title here


    
        <%@ taglib uri="/struts-tags" prefix="s"%>

Registration.jsp redirecting to the getRegistered action:

LoginAction-Validation.xml




    
    
        
            true
            User Name is mandatory
        
        
            5
            10
            true
            User Name must be between 5 to 10 characters long
        
    

    
        
            true
            Enter your password
        
        
            5
            10
            true
            Password must be between 5 to 10 characters long
        
        
            ((?=.*\d)(?=.*[a-z])(?=.*[A-Z])(?=.*[@#$%]).{5,10})
            Password must

Validation xml for the login user name and the password..

When I run this code, it is always returning the "INPUT" string and redirecting to LoginError.jsp in the case of login action and login.jsp in the case of register action. Please suggest how I can resolve this issue without using validation.excludeMethods

LoginAction-getRegistered-validation.xml:





    
        
            true
            Firstname is mandatory
        
        
            5
            10
            true
            First Name must be between 5 to 10 characters long
        
    
    
        
            true
            Lastname is mandatory
        
        
            5
            10
            true
            Last Name must be between 5 to 10 characters long

I have made validation for the first and the last name

Roman C · Accepted Answer

In your validation file which is per class, so it validates all actions/methods in this class that are intercepted by validation interceptor. You should separate validation logic for the first action getLogin like LoginAction-getLogin-validation.xml and define another validation file for getRegistered action like LoginAction-getRegistered-validation.xml. They would be processed per action. Also regex validator has a parameter regex instead of expression.


  
  Password must

Not able to call two different methods under same action class without using validation.excludeMethods

Answers (2)

Related Questions