CODEWITHSUNDEEP
javajmsweblogicspring-3
freecouch
freecouch

Reputation: 233

Spring / WebLogic - JMS message not redelivered on failure

I am using WerbLogic 10.3.5 and Spring 3.0 to implement a JMS queue. I have the following Spring configuration:

    <!--  JMS Configuration -->
<bean id="paymentlistener" class="com.myproject.service.impl.PaymentListener"/> 

<bean id="paymentlistenerContainer" class="org.springframework.jms.listener.DefaultMessageListenerContainer">
    <property name="concurrentConsumers" value="10"/>
    <property name="connectionFactory" ref="paymentConnectionFactory"/>
    <property name="destination" ref="paymentQueue"/>
    <property name="messageListener" ref="paymentlistener"/>
</bean>

<bean id="paymentQueue" class="org.springframework.jndi.JndiObjectFactoryBean">
    <property name="jndiName" value="jms/paymentResponseHandlerQueue"/>
    <property name="jndiTemplate" ref="jndiTemplate"/>
</bean>

<bean id="jndiTemplate" class="org.springframework.jndi.JndiTemplate">
    <property name="environment">
        <props>
            <prop key="java.naming.factory.initial">weblogic.jndi.WLInitialContextFactory</prop>
            <prop key="java.naming.provider.url">t3://localhost:7001</prop>
        </props>
    </property>
</bean>

<bean id="paymentConnectionFactory" class="org.springframework.jndi.JndiObjectFactoryBean">
    <property name="jndiTemplate" ref="jndiTemplate"/>
    <property name="jndiName" value="jms/paymentResponseHandlerConnectionFactory"/>
</bean>

<bean id="jmsDestinationResolver" class="org.springframework.jms.support.destination.JndiDestinationResolver">
    <property name="jndiTemplate" ref="jndiTemplate"/>
    <property name="cache" value="true"/>
</bean>

<bean id="jmsTemplate" class="org.springframework.jms.core.JmsTemplate">
    <property name="connectionFactory" ref="paymentConnectionFactory"/>
    <property name="destinationResolver" ref="jmsDestinationResolver"/>
    <property name="defaultDestination" ref="paymentQueue"/>
    <property name="sessionAcknowledgeModeName" value="DUPS_OK_ACKNOWLEDGE"/>
    <property name="sessionTransacted" value="true"/>
</bean>

My message creation code looks like this:

    MessageCreator messageCreator = new MessageCreator() {
        public Message createMessage(Session session) throws JMSException {
                logger.debug("Session ack mode: " + session.getAcknowledgeMode());
                return session.createObjectMessage(payment);
        }
    };


    jmsTemplate.send("jms/paymentResponseHandlerQueue", messageCreator);

And my listener looks like this:

@Override
public void onMessage(Message message) { // , Session session
if (!(message instanceof ObjectMessage)) {
    throw new IllegalStateException("The PaymentListener queue expects an object message"); 
}

ObjectMessage objectMessage = (ObjectMessage) message;

try {
    logger.debug("Is Message redelivered:" + objectMessage.getJMSRedelivered ());

    if (objectMessage.getObject() instanceof CreditCardPaymentDTO) {

        logger.debug("Object is of type CreditCardPaymentDTO");

        // The user that just logged in
        CreditCardPaymentDTO payment  = (CreditCardPaymentDTO) objectMessage.getObject();               
        otpCollectorDAO.savePayment(payment);
    }
} catch (JMSException e) {
    logger.error(e);
    throw new RuntimeException(e);
} catch (PaymentResponseException e) {
    logger.error(e);
    throw new RuntimeException(e);
}
}

The message is being created correctly, and the onMessage() method of my listener is being called, but if the logic fails and I throw a RuntimeException(), the message does not get redelivered. I've tried many slight variations of the above code (eg. setting sessionAcknowledgeModeName=SESSION_TRANSACTED and explicitly rolling back the transaction), but the message is never re-queued. What is the trick to getting failed messages to redeliver?

Upvotes: 3

Views: 1266

Answers (1)

Andrei Stefan
Andrei Stefan

Reputation: 52366

I believe you need to set sessionTransacted to true for the DefaultMessageListenerContainer:

<bean id="paymentlistenerContainer" class="org.springframework.jms.listener.DefaultMessageListenerContainer">
    ...
    <property name="sessionTransacted" value="true"/>
</bean>

You can find here relevant reference documentation.

Upvotes: 3

Related Questions