CODEWITHSUNDEEP
javascripthtmlcalculator
user2014557
user2014557

Reputation: 35

I'm getting a NaN error

I'm getting a NaN error in this calculator script: Any ideas?

Here is the whole html in a text format:

https://www.dropbox.com/s/i3u429bn5bjd4i9/orecalculator.txt

<script language="JavaScript">

var IDs = [22,17425,17426,1223,17428,17429,1225,17432,17433,1232,17436,17437,1229,17865,17866,21,17440,17441,1231,17444,17445,1226,17448,17449,20,17452,17453,11396,17869,17870,1227,17867,17868,18,17455,17456,1224,17459,17460,1228,17463,17464,19,17466,17467,1230,17470,17471];

function calculate(i){
    while (i + 1 < IDs.length) {
        var y=document.getElementById('reward');
        var x=document.getElementById(IDs[i]);
        y.value=parseInt(y.value)+parseInt(x.value);
        i++;
    }
}
</script>

Upvotes: 1

Views: 704

Answers (2)

Harpreet Singh
Harpreet Singh

Reputation: 2671

I have Run this code in console and found following output

document.getElementById('reward')
//output <input type=​"text" id=​"reward">​
document.getElementById('reward').value
//""
parseInt(document.getElementById('reward').value)
//NaN
parseInt("")
//NaN

Explanation

parseInt of empty string is NaN

Solution

Use

Reward: <input type="text" id="reward" value="0">

instead

Reward: <input type="text" id="reward">

Fixed: JS Code

function calculate(i){
    while (i + 1 < IDs.length) {
        var y=document.getElementById('reward');
        var x=document.getElementById(IDs[i]);
        y.value=parseInt(y.value|0)+parseInt(x.value|0);
        i++;
    }
}

Upvotes: 3

George
George

Reputation: 4413

untested but should be something like this:

calculate = function (i){

    var y = document.getElementById('reward');
    var x = 0;  
    while (i + 1 < IDs.length) {

        var elm = document.getElementById(IDs[i]);
        x+=parseInt(elm.value||0);
        i++;
    }
    y.value = x;
};

working fiddle:

http://jsfiddle.net/g30rg3/8ADQX/

Upvotes: 0

Related Questions