CODEWITHSUNDEEP
c#linqrefactoring
CurlyFro
CurlyFro

Reputation: 1882

how do i refactor these linq properties?

i have 4 class properties that have similar signatures but going to different linq properties. how do i create a delegate or something to clean this up?

for example: 

    public IEnumerable<SelectListItem> DistinctUsers
    {
        get
        {
            var list = TraceLogs.OrderBy(x => x.Username).Select(x => x.Username).Distinct();
            return (from s in list select new SelectListItem { Value = s, Text = s }
           );
        }
    }

    public IEnumerable<SelectListItem> DistinctMethods
    {
        get
        {
            var list = TraceLogs.OrderBy(x => x.Method).Select(x => x.Method).Distinct();
            return (from s in list select new SelectListItem { Value = s, Text = s }
           );
        }
    }

Upvotes: 0

Views: 96

Answers (1)

Jon Skeet
Jon Skeet

Reputation: 1500815

It sounds like you want somethng like:

private IEnumerable<SelectListItem> GetDistinctOrderedLogs<T>
    (Func<TraceLogs, T> extraction)
{
    return TraceLogs.OrderBy(extraction)
                    .Select(extraction)
                    .Distinct()
                    .Select(s => new SelectListItem { Value = s, Text = s });
}

Then:

public IEnumerable<SelectListItem> DistinctMethods
{
    get { return GetDistinctOrderedLogs(t => t.Method); }
}

public IEnumerable<SelectListItem> DistinctUsers
{
    get { return GetDistinctOrderedLogs(t => t.Users); }
}

Upvotes: 7

Related Questions