CODEWITHSUNDEEP
springspring-mvc
Felix
Felix

Reputation: 1263

spring mvc add custom resolver and get 500 error

I am trying to add a custom resolver in my spring mvc project. resolver code is here :

public class CurrentUserWebArgumentResolver implements WebArgumentResolver {

    @Override
    public Object resolveArgument(MethodParameter methodParameter, NativeWebRequest webRequest) throws Exception {
        if (methodParameter.getParameterType().equals(User.class)) {
            User host = (User)webRequest.getAttribute(WebConstant.HTTP_REQUEST_HOST_NAME, RequestAttributes.SCOPE_REQUEST);
            return host;
        }
        return null;
    }
}

and I change the default annotation spring config :

<mvc:annotation-driven >
        <mvc:argument-resolvers>
            <bean class="com.xxx.web.resolver.CurrentUserWebArgumentResolver" />
        </mvc:argument-resolvers>
    </mvc:annotation-driven>

and my controllers function is here :

@RequestMapping(value = "register", method = RequestMethod.POST)
    public ModelAndView store(@Valid RegisterForm registerForm, BindingResult result) {
        ModelAndView mv = new ModelAndView("user/register");
        if (result.hasErrors()) {
            return mv;
        }
        User user = registerForm.getUser();
        if (registerService.register(user)) {
            mv.setView(new RedirectView("/"));
        }
        return mv;
    }

now when I request this url I get this error :

org.springframework.web.util.NestedServletException: Request processing failed; nested exception is java.lang.IllegalStateException: An Errors/BindingResult argument is expected to be declared immediately after the model attribute, the @RequestBody or the @RequestPart arguments to which they apply: public org.springframework.web.servlet.ModelAndView com.xxx.web.controller.user.RegisterController.store(com.xxx.web.validate.form.user.RegisterForm,org.springframework.validation.BindingResult)
    org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:927)
    org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:822)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:646)
    org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:796)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
    org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:88)
    org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
root cause

java.lang.IllegalStateException: An Errors/BindingResult argument is expected to be declared immediately after the model attribute, the @RequestBody or the @RequestPart arguments to which they apply: public org.springframework.web.servlet.ModelAndView com.xxx.web.controller.user.RegisterController.store(com.xxx.web.validate.form.user.RegisterForm,org.springframework.validation.BindingResult)
    org.springframework.web.method.annotation.ErrorsMethodArgumentResolver.resolveArgument(ErrorsMethodArgumentResolver.java:62)
    org.springframework.web.method.support.HandlerMethodArgumentResolverComposite.resolveArgument(HandlerMethodArgumentResolverComposite.java:77)
    org.springframework.web.method.support.InvocableHandlerMethod.getMethodArgumentValues(InvocableHandlerMethod.java:162)
    org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:123)
    org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:104)
    org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandleMethod(RequestMappingHandlerAdapter.java:746)
    org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:687)
    org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:80)
    org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:925)
    org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:856)
    org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:915)
    org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:822)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:646)
    org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:796)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
    org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:88)
    org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)

I think there must be some other resolvers I didn`t add into the spring config file

please help me thanks

Upvotes: 0

Views: 803

Answers (1)

M. Deinum
M. Deinum

Reputation: 124601

You are violating the contract

Returns: the argument value, or UNRESOLVED if not resolvable

You are returning null violating the contract. Replace with the UNRESOLVED static variable.

public class CurrentUserWebArgumentResolver implements WebArgumentResolver {

    @Override
    public Object resolveArgument(MethodParameter methodParameter, NativeWebRequest webRequest) throws Exception {
        if (methodParameter.getParameterType().equals(User.class)) {
            User host = (User)webRequest.getAttribute(WebConstant.HTTP_REQUEST_HOST_NAME, RequestAttributes.SCOPE_REQUEST);
            return host;
        }
        return UNRESOLVED;
    }
}

Upvotes: 2

Related Questions